some validation clean up

Author: eadwinCode

ellar_cli/file_scaffolding.py

@@ -28,8 +28,6 @@ def __init__(
         specified_directory: t.Optional[str] = None,
     ) -> None:
         self._specified_directory = specified_directory
-        if specified_directory and specified_directory.startswith("/"):
-            self._specified_directory = specified_directory[1:]
 
         self._schema = schema
         self._ctx = ProjectScaffoldContext(Environment())

ellar_cli/manage_commands/new.py

@@ -85,12 +85,6 @@ def is_directory_empty(self) -> bool:
         return True
 
     def validate_project_name(self) -> None:
-        if os.path.exists(self._working_project_name):
-            message = "A folder with same name exist '{name}' ".format(
-                name=self._working_project_name
-            )
-            raise EllarCLIException(message)
-
         if not self.is_directory_empty():
             working_project_dir = os.path.join(
                 self._working_directory, self._working_project_name

tests/test_ellar_commands/test_new_command.py

@@ -25,7 +25,7 @@ def test_new_command_works(tmpdir, process_runner):
     }
 
 
-def test_new_command_works_with_specific_directory(tmpdir, process_runner):
+def test_new_command_works_with_specific_directory_case_1(tmpdir, process_runner):
     result = process_runner(["ellar", "new", "ellar-project-new", "Another/me"])
     assert result.returncode == 0
     assert result.stdout.decode("utf8") == (
@@ -45,6 +45,25 @@ def test_new_command_works_with_specific_directory(tmpdir, process_runner):
     }
 
 
+def test_new_command_works_with_specific_directory_case_3(tmpdir, process_runner):
+    _path = tmpdir / "23-August-2023"
+    os.makedirs(_path)
+    result = process_runner(["ellar", "new", "ellar-project-new", str(_path)])
+    assert result.returncode == 0
+    assert (
+        "ellar --project ellar_project_new runserver --reload"
+        in result.stdout.decode("utf8")
+    )
+    os.chdir(os.path.join(_path))
+    ellar_cli_service = EllarCLIService.import_project_meta()
+    assert ellar_cli_service._meta.dict() == {
+        "project_name": "ellar_project_new",
+        "application": "ellar_project_new.server:application",
+        "config": "ellar_project_new.config:DevelopmentConfig",
+        "root_module": "ellar_project_new.root_module:ApplicationModule",
+    }
+
+
 def test_new_command_fails_case_1(tmpdir, process_runner):
     result = process_runner(["ellar", "new", "ellar-project-new", "Another/me"])
     assert result.returncode == 0
@@ -72,13 +91,13 @@ def test_new_command_works_with_specific_directory_case_2(tmpdir, process_runner
     }
 
 
-def test_new_command_fails_for_existing_folder_name(tmp_path, process_runner):
-    os.makedirs(tmp_path / "ellar-project-exist", exist_ok=True)
-    result = process_runner(["ellar", "new", "ellar-project-exist"])
-    assert result.returncode == 1
-    assert result.stderr.decode("utf8") == (
-        "Error: A folder with same name exist 'ellar-project-exist' \n"
-    )
+# def test_new_command_fails_for_existing_folder_name(tmp_path, process_runner):
+#     os.makedirs(tmp_path / "ellar-project-exist", exist_ok=True)
+#     result = process_runner(["ellar", "new", "ellar-project-exist"])
+#     assert result.returncode == 1
+#     assert result.stderr.decode("utf8") == (
+#         "Error: A folder with same name exist 'ellar-project-exist' \n"
+#     )
 
 
 def test_new_command_fails_for_invalid_project_name(tmp_path, process_runner):