Skip to content

Commit d936299

Browse files
committed
fixed failing test
1 parent 42aa11a commit d936299

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

tests/test_ellar_cli_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_import_project_meta_returns_default_when_py_project_does_not_have_ellar
2424
assert ellar_cli_service._meta is None
2525
assert ellar_cli_service.py_project_path == os.path.join(tmpdir, PY_PROJECT_TOML)
2626
assert ellar_cli_service.cwd == tmpdir
27-
assert ellar_cli_service.app is None
27+
assert ellar_cli_service.app == "ellar"
2828
assert ellar_cli_service.ellar_py_projects.default_project is None
2929
assert ellar_cli_service.ellar_py_projects.has_default_project is False
3030

tests/test_ellar_commands/test_create_module_command.py

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,23 @@ def test_create_module_fails_if_no_project_is_found(cli_runner, write_empty_py_p
1818

1919

2020
def test_create_module_fails_for_invalid_module_name(
21-
cli_runner, write_empty_py_project
21+
process_runner, write_empty_py_project
2222
):
23-
result = cli_runner.invoke_ellar_command(["create-project", "testing_new_project"])
24-
assert result.exit_code == 0
25-
result = cli_runner.invoke_ellar_command(["create-module", "testing-new-module"])
26-
assert result.exit_code == 1
27-
assert result.output == (
23+
result = process_runner(["ellar", "create-project", "testing_new_project"])
24+
assert result.returncode == 0
25+
result = process_runner(["ellar", "create-module", "testing-new-module"])
26+
assert result.returncode == 1
27+
assert result.stderr.decode("utf8") == (
2828
"Error: 'testing-new-module' is not a valid module-name. "
2929
"Please make sure the module-name is a valid identifier.\n"
3030
)
3131

3232

3333
def test_create_module_fails_for_existing_module_project_name(
34-
cli_runner, write_empty_py_project
34+
process_runner, write_empty_py_project
3535
):
36-
result = cli_runner.invoke_ellar_command(
37-
["create-project", "testing_new_project_two"]
38-
)
39-
assert result.exit_code == 0
36+
result = process_runner(["ellar", "create-project", "testing_new_project_two"])
37+
assert result.returncode == 0
4038
ellar_cli_service = EllarCLIService.import_project_meta("testing_new_project_two")
4139
module_name = "new_module_name"
4240
with open(
@@ -45,11 +43,11 @@ def test_create_module_fails_for_existing_module_project_name(
4543
) as fp:
4644
fp.write("")
4745

48-
result = cli_runner.invoke_ellar_command(
49-
["--project=testing_new_project_two", "create-module", module_name]
46+
result = process_runner(
47+
["ellar", "--project=testing_new_project_two", "create-module", module_name]
5048
)
51-
assert result.exit_code == 1
52-
assert result.output == (
49+
assert result.returncode == 1
50+
assert result.stderr.decode("utf8") == (
5351
"Error: 'new_module_name' conflicts with the name of an existing "
5452
"Python module and cannot be used as a module-name. Please try another module-name.\n"
5553
)

0 commit comments

Comments
 (0)