Skip to content

Commit 227d11f

Browse files
committed
fixed failing tests
1 parent 25c3b13 commit 227d11f

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

ellar/core/response/model/base.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,10 @@ def __init__(
8484
self.description = description
8585
self.meta = kwargs
8686

87-
_schema: t.Optional[ResponseModelField] = None
88-
if (
89-
schema
90-
or self.model_schema
91-
and not isinstance(schema or self.model_schema, ResponseModelField)
92-
):
87+
_schema: t.Optional[ResponseModelField] = schema or self.model_schema
88+
if _schema and not isinstance(_schema, ResponseModelField):
9389
new_response_schema = ResponseTypeDefinitionConverter(
94-
schema or self.model_schema
90+
_schema
9591
).re_group_outer_type()
9692

9793
_schema = t.cast(

tests/test_response/test_route_response_model.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class JsonApiResponseModel(ResponseModel):
3333
"application/json",
3434
),
3535
(
36-
{200: EmptyAPIResponseModel.create_model()},
36+
{200: EmptyAPIResponseModel()},
3737
EmptyAPIResponseModel,
3838
200,
3939
"Successful Response",
@@ -42,7 +42,7 @@ class JsonApiResponseModel(ResponseModel):
4242
(
4343
{
4444
201: (Union[NoteSchemaDC, BlogObjectDTO], "Create Note"),
45-
200: EmptyAPIResponseModel.create_model(),
45+
200: EmptyAPIResponseModel(),
4646
},
4747
JSONResponseModel,
4848
201,
@@ -52,15 +52,15 @@ class JsonApiResponseModel(ResponseModel):
5252
(
5353
{
5454
201: (Union[NoteSchemaDC, BlogObjectDTO], "Create Note"),
55-
200: EmptyAPIResponseModel.create_model(),
55+
200: EmptyAPIResponseModel(),
5656
},
5757
JSONResponseModel,
5858
200,
5959
"Successful Response",
6060
"application/json",
6161
),
6262
(
63-
{200: JsonApiResponseModel.create_model()},
63+
{200: JsonApiResponseModel()},
6464
JsonApiResponseModel,
6565
200,
6666
"Successful Response",

0 commit comments

Comments
 (0)