Merge pull request #293 from python-ellar/mypy_fix3oct

Fix mypy errors: resolve type issues and remove unused type ignores

Author: eadwinCode

Makefile

@@ -5,11 +5,11 @@ help:
 	@fgrep -h "##" $(MAKEFILE_LIST) | fgrep -v fgrep | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
 
 clean: ## Removing cached python compiled files
-	find . -name \*pyc  | xargs  rm -fv
-	find . -name \*pyo | xargs  rm -fv
-	find . -name \*~  | xargs  rm -fv
-	find . -name __pycache__  | xargs  rm -rfv
-	find . -name .ruff_cache  | xargs  rm -rfv
+	find . -name "*.pyc" -type f -delete
+	find . -name "*.pyo" -type f -delete
+	find . -name "*~" -type f -delete
+	find . -name "__pycache__" -type d -exec rm -rf {} + 2>/dev/null || true
+	find . -name ".ruff_cache" -type d -exec rm -rf {} + 2>/dev/null || true
 
 install: ## Install dependencies
 	pip install -r requirements.txt

ellar/app/lifespan.py

@@ -60,7 +60,7 @@ async def lifespan(self, app: "App") -> t.AsyncIterator[t.Any]:
             logger.debug("Executing Modules Startup Handlers")
             await self.run_all_startup_actions(app)
 
-            async with self._lifespan_context(app) as ctx:  # type:ignore[attr-defined]
+            async with self._lifespan_context(app) as ctx:
                 logger.info("Application is ready.")
                 yield ctx
         finally:

ellar/app/main.py

@@ -53,9 +53,9 @@ def __init__(
     ):
         _routes = routes or []
         assert isinstance(config, Config), "config must instance of Config"
-        assert isinstance(
-            injector, EllarInjector
-        ), "injector must instance of EllarInjector"
+        assert isinstance(injector, EllarInjector), (
+            "injector must instance of EllarInjector"
+        )
 
         self._config = config
         self._injector: EllarInjector = injector
@@ -70,7 +70,7 @@ def __init__(
             redirect_slashes=self.config.REDIRECT_SLASHES,
             default=self.config.DEFAULT_NOT_FOUND_HANDLER,
             lifespan=EllarApplicationLifespan(
-                self.config.DEFAULT_LIFESPAN_HANDLER  # type: ignore[arg-type]
+                self.config.DEFAULT_LIFESPAN_HANDLER
             ).lifespan,
         )
 

ellar/auth/handlers/schemes/http.py

@@ -94,7 +94,7 @@ def _get_credentials(self, connection: "HTTPConnection") -> HTTPBasicCredentials
 
         if not separator:
             self._not_unauthorized_exception("Invalid authentication credentials")
-        return HTTPBasicCredentials(username=username, password=password)  # type: ignore[arg-type]
+        return HTTPBasicCredentials(username=username, password=password)
 
 
 class HttpDigestAuth(HttpBearerAuth, ABC):

ellar/auth/policy/base.py

@@ -19,7 +19,7 @@ class MyPolicyHandler(PolicyWithRequirement):
     """
 
     def __init__(self, *args: t.Any) -> None:
-        kwargs_args = {f"arg_{idx+1}": value for idx, value in enumerate(args)}
+        kwargs_args = {f"arg_{idx + 1}": value for idx, value in enumerate(args)}
         super().__init__(kwargs_args)
 
 

ellar/cache/module.py

@@ -34,7 +34,7 @@ def setup(
         args = {"default": default}
         args.update(kwargs)
 
-        schema = CacheModuleSchemaSetup(**{"CACHES": args})  # type: ignore[arg-type]
+        schema = CacheModuleSchemaSetup(**{"CACHES": args})
         return cls._create_dynamic_module(schema)
 
     @classmethod

ellar/cache/service.py

@@ -84,9 +84,9 @@ def __init__(
         self, backends: t.Optional[t.Dict[str, BaseCacheBackend]] = None
     ) -> None:
         if backends:
-            assert backends.get(
-                "default"
-            ), "CACHES configuration must have a 'default' key."
+            assert backends.get("default"), (
+                "CACHES configuration must have a 'default' key."
+            )
         self._backends = backends or {
             "default": LocalMemCacheBackend(key_prefix="ellar", version=1, ttl=300)
         }

ellar/common/decorators/controller.py

@@ -42,9 +42,9 @@ def Controller(
         _prefix = NOT_SET
 
     if _prefix is not NOT_SET:
-        assert _prefix == "" or str(_prefix).startswith(
-            "/"
-        ), "Controller Prefix must start with '/'"
+        assert _prefix == "" or str(_prefix).startswith("/"), (
+            "Controller Prefix must start with '/'"
+        )
     # TODO: replace with a ControllerTypeDict and OpenAPITypeDict
     kwargs = AttributeDict(
         path=_prefix,

ellar/common/decorators/html.py

@@ -41,9 +41,9 @@ def render(template_name: t.Optional[str] = NOT_SET) -> t.Callable:
     :return:
     """
     if template_name is not NOT_SET:
-        assert isinstance(
-            template_name, str
-        ), "Render Operation must invoked eg. @render()"
+        assert isinstance(template_name, str), (
+            "Render Operation must invoked eg. @render()"
+        )
     template_name = None if template_name is NOT_SET else template_name
 
     def _decorator(func: t.Union[t.Callable, t.Any]) -> t.Union[t.Callable, t.Any]:

ellar/common/decorators/modules.py

@@ -91,7 +91,7 @@ def Module(
 
     :return: t.TYPE[ModuleBase]
     """
-    base_directory = get_main_directory_by_stack(base_directory, stack_level=2)  # type:ignore[arg-type]
+    base_directory = get_main_directory_by_stack(base_directory, stack_level=2)
     kwargs = AttributeDict(
         name=name,
         controllers=list(controllers),