Merge pull request #215 from python-ellar/test_fix

fix: TestingModule metadata sharing during tests

Author: eadwinCode

ellar/__init__.py

@@ -1,3 +1,3 @@
 """Ellar - Python ASGI web framework for building fast, efficient, and scalable RESTful APIs and server-side applications."""
 
-__version__ = "0.7.6"
+__version__ = "0.7.7"

ellar/testing/module.py

@@ -5,9 +5,10 @@
 from ellar.app import App, AppFactory
 from ellar.common import ControllerBase, Module, ModuleRouter
 from ellar.common.types import T
-from ellar.core import ModuleBase
+from ellar.core import DynamicModule, ModuleBase, ModuleSetup
 from ellar.core.routing import EllarMount
 from ellar.di import ProviderConfig
+from ellar.utils import get_name
 from starlette.routing import Host, Mount
 from starlette.testclient import TestClient as TestClient
 
@@ -100,20 +101,39 @@ def create_test_module(
             t.List[t.Union[t.Type["GuardCanActivate"], "GuardCanActivate"]]
         ] = None,
         config_module: t.Optional[t.Union[str, t.Dict]] = None,
+        modify_modules: bool = True,
     ) -> TESTING_MODULE:  # type: ignore[valid-type]
         """
         Create a TestingModule to test controllers and services in isolation
-        :param modules:
-        :param controllers:
-        :param routers:
-        :param providers:
-        :param template_folder:
-        :param base_directory:
-        :param static_folder:
-        :param config_module:
-        :param global_guards:
+        :param modules: Other module dependencies
+        :param controllers: Module Controllers
+        :param routers: Module router
+        :param providers: Module Services
+        :param template_folder: Module Templating folder
+        :param base_directory: Base Directory for static folder and template
+        :param static_folder: Module Static folder
+        :param config_module: Application Config
+        :param global_guards: Application Guard
+        :param modify_modules: Modifies Modules
+        if setup or register_setup is used to avoid module sharing metadata between tests
         :return:
         """
+
+        if modify_modules:
+
+            def modifier_module(
+                _module: t.Union[t.Type, t.Any],
+            ) -> t.Union[t.Type, t.Any]:
+                return Module()(
+                    type(
+                        f"{get_name(_module)}Modified_{uuid4().hex[:6]}", (_module,), {}
+                    )
+                )
+
+            for module_ in modules:
+                if isinstance(module_, (ModuleSetup, DynamicModule)):
+                    module_.module = modifier_module(module_.module)
+
         module = Module(
             modules=modules,
             controllers=controllers,

tests/test_modules/test_module_config.py

@@ -200,7 +200,7 @@ def test_dynamic_module_haves_routes():
     mount0 = ModuleRouterBuilder.build(routers[0])
     assert len(mount0.routes) == 39
     tm = Test.create_test_module(
-        modules=(DynamicInstantiatedModule.setup(a=233, b=344),)
+        modules=(DynamicInstantiatedModule.setup(a=233, b=344),), modify_modules=False
     )
     tm.create_application()
     routers = reflect.get_metadata(MODULE_METADATA.ROUTERS, DynamicInstantiatedModule)