added test to fix coverage

Author: eadwinCode

ellar/common/params/resolvers/parameter.py

@@ -143,7 +143,7 @@ async def get_request_body(self, ctx: IExecutionContext) -> t.Any:
             return body_bytes
         except json.JSONDecodeError as e:
             raise RequestValidationError([ErrorWrapper(e, ("body", e.pos))]) from e
-        except Exception as e:
+        except Exception as e:  # pragma: no cover
             raise HTTPException(
                 status_code=400, detail="There was an error parsing the body"
             ) from e

tests/test_routing/test_body_schema.py

@@ -107,3 +107,38 @@ def test_get_with_body(test_client_factory):
     body = {"name": "Foo", "description": "Some description", "price": 5.5}
     response = client.post("/product", json=body)
     assert response.json() == body
+
+
+def test_body_fails_for_invalid_json_data(test_client_factory):
+    client = test_client_factory(app)
+    body = """
+{
+    "name": "John",
+    "age": 30,
+    "is_student": True,
+    "favorite_colors": ["red", "blue", "green"],
+    "address": {
+        "street": "123 Main St",
+        "city": "Some City",
+        "zip": "12345"
+    },
+    "unterminated_quote": "This string is not properly terminated,
+}
+"""
+    response = client.post("/product", data=body)
+    assert response.json() == {
+        "detail": [
+            {
+                "loc": ["body", 56],
+                "msg": "Expecting value: line 5 column 19 (char 56)",
+                "type": "value_error.jsondecode",
+                "ctx": {
+                    "msg": "Expecting value",
+                    "doc": '\n{\n    "name": "John",\n    "age": 30,\n    "is_student": True,\n    "favorite_colors": ["red", "blue", "green"],\n    "address": {\n        "street": "123 Main St",\n        "city": "Some City",\n        "zip": "12345"\n    },\n    "unterminated_quote": "This string is not properly terminated,\n}\n',
+                    "pos": 56,
+                    "lineno": 5,
+                    "colno": 19,
+                },
+            }
+        ]
+    }

tests/test_routing/test_body_union_schema.py

@@ -1,6 +1,6 @@
 from typing import Union
 
-from ellar.common import post
+from ellar.common import Body, post
 from ellar.common.serializer import serialize_object
 from ellar.openapi import OpenAPIDocumentBuilder
 from ellar.testing import Test
@@ -11,12 +11,14 @@
 
 
 @post("/items/")
-def save_union_body(item: Union[OtherItem, Item]):
-    return {"item": item}
+def save_union_body_and_embedded_body(
+    item: Union[OtherItem, Item], qty: int = Body(12)
+):
+    return {"item": item, "qty": qty}
 
 
 app = tm.create_application()
-app.router.append(save_union_body)
+app.router.append(save_union_body_and_embedded_body)
 
 client = tm.get_test_client()
 
@@ -32,11 +34,7 @@ def save_union_body(item: Union[OtherItem, Item]):
                     "content": {
                         "application/json": {
                             "schema": {
-                                "title": "Item",
-                                "anyOf": [
-                                    {"$ref": "#/components/schemas/OtherItem"},
-                                    {"$ref": "#/components/schemas/Item"},
-                                ],
+                                "$ref": "#/components/schemas/body_save_union_body_items__post"
                             }
                         }
                     },
@@ -104,6 +102,21 @@ def save_union_body(item: Union[OtherItem, Item]):
                     "type": {"title": "Error Type", "type": "string"},
                 },
             },
+            "body_save_union_body_items__post": {
+                "title": "body_save_union_body_items__post",
+                "required": ["item"],
+                "type": "object",
+                "properties": {
+                    "item": {
+                        "title": "Item",
+                        "anyOf": [
+                            {"$ref": "#/components/schemas/OtherItem"},
+                            {"$ref": "#/components/schemas/Item"},
+                        ],
+                    },
+                    "qty": {"title": "Qty", "type": "integer", "default": 12},
+                },
+            },
         }
     },
     "tags": [],
@@ -116,12 +129,12 @@ def test_item_openapi_schema():
 
 
 def test_post_other_item():
-    response = client.post("/items/", json={"price": 100})
+    response = client.post("/items/", json={"item": {"price": 100}})
     assert response.status_code == 200, response.text
-    assert response.json() == {"item": {"price": 100}}
+    assert response.json() == {"item": {"price": 100}, "qty": 12}
 
 
 def test_post_item():
-    response = client.post("/items/", json={"name": "Foo"})
+    response = client.post("/items/", json={"item": {"name": "Foo"}})
     assert response.status_code == 200, response.text
-    assert response.json() == {"item": {"name": "Foo"}}
+    assert response.json() == {"item": {"name": "Foo"}, "qty": 12}