removing commented codes

Author: eadwinCode

ellar/app/main.py

@@ -388,12 +388,6 @@ def setup_jinja_environment(self) -> Environment:
         """Sets up Jinja2 Environment and adds it to DI"""
         jinja_environment = self._create_jinja_environment()
 
-        # self.injector.module_info.ref.add_provider(
-        #     ProviderConfig(Environment, use_value=jinja_environment), export=True
-        # )
-        # self.injector.module_info.ref.add_provider(
-        #     ProviderConfig(JinjaEnvironment, use_value=jinja_environment), export=True
-        # )
         self.injector.tree_manager.get_root_module().add_provider(
             ProviderConfig(Environment, use_value=jinja_environment), export=True
         )

ellar/core/modules/ref/base.py

@@ -53,18 +53,6 @@ def __init__(
         self._exports: t.List[t.Type] = []
         self._providers: t.Dict[t.Type, t.Type] = {}
 
-        # if self.container.injector.parent:
-        #     parent_module = None
-        #     if self.container.injector.parent.module_info:
-        #         parent_module = self.container.injector.parent.module_info.module
-        #
-        #     self.container.injector.tree_manager.add_or_update(
-        #         module_type=self.module, value=self, parent_module=parent_module
-        #     )
-        #
-        # if not build_manually:
-        # self._init_module_build()
-
     def __repr__(self) -> str:
         return f"<{self.__class__.__name__} name={self.name} module={self.module}>"
 
@@ -202,14 +190,6 @@ def _validate_() -> None:
     def add_provider(
         self, provider: t.Union[t.Type, ProviderConfig, t.Any], export: bool = False
     ) -> None:
-        # existing = next(
-        #     self.container.injector.tree_manager.find_module(
-        #         lambda data: provider.get_type() in data.providers and data.value.module == self.module
-        #     )
-        # )
-        #
-        # self.container.injector.tree_manager.add_provider(self.module, provider_type)
-
         if not isinstance(provider, ProviderConfig):
             provider = ProviderConfig(provider, export=export)
 

tests/test_di/test_tree_manager.py

@@ -8,10 +8,10 @@
 
 
 def test_root_module_assert_should_raise_exception():
-    ModuleTreeManager()
+    tree_manager = ModuleTreeManager()
 
     with pytest.raises(AssertionError):
-        pass
+        assert tree_manager.root_module
 
 
 def test_add_provider_fails_for_none_existing_module():

tests/test_modules/test_module_config.py

@@ -3,6 +3,7 @@
 
 import click
 import pytest
+from ellar.app import App
 from ellar.common import (
     Controller,
     ControllerBase,
@@ -248,13 +249,13 @@ def test_dynamic_module_setup_register_works(reflect_context):
 @pytest.mark.parametrize(
     "name, dependencies",
     [
-        # ("depends on nothing but has factory", []),
-        # ("depends only on config", [Config]),
+        ("depends on nothing but has factory", []),
+        ("depends only on config", [Config]),
         ("depends on other services", [Config, Reflector]),
-        # (
-        #     "depends on other services and Application instance",
-        #     [Config, Reflector, App],
-        # ),
+        (
+            "depends on other services and Application instance",
+            [Config, Reflector, App],
+        ),
     ],
 )
 def test_module_setup_with_factory_works(name, dependencies, reflect_context):