Implement more tests (which may raise SyntaxError for us)

Author: domdfcoding

tests/upstream_tests/match_test.py

@@ -7,26 +7,29 @@
 # this package
 from formate_trailing_commas import trailing_commas_hook
 
-# TODO
-# @pytest.mark.parametrize(
-#     's',
-#     (
-#         pytest.param(
-#             'match x:\n'
-#             '    case 1, 2:\n'
-#             '        pass\n',
-#             id='sequence without braces',
-#         ),
-#         pytest.param(
-#             'match x:\n'
-#             '    case a():\n'
-#             '        pass\n',
-#             id='class without args',
-#         ),
-#     ),
-# )
-# def test_noop(s):
-#     assert trailing_commas_hook(s, min_version=(2, 7)) == s
+@pytest.mark.parametrize(
+		's',
+		(
+				pytest.param(
+						'match x:\n'
+						'    case 1, 2:\n'
+						'        pass\n',
+						id="sequence without braces",
+						),
+				pytest.param(
+						'match x:\n'
+						'    case a():\n'
+						'        pass\n',
+						id="class without args",
+						),
+				),
+		)
+def test_noop_or_syntaxerror(s):
+	if sys.version_info >= (3, 10):
+		assert trailing_commas_hook(s, min_version=(2, 7)) == s
+	else:
+		with pytest.raises(SyntaxError, match="invalid syntax"):
+			trailing_commas_hook(s, min_version=(2, 7))
 
 
 @pytest.mark.xfail(sys.version_info < (3, 10), reason="py310+")

tests/upstream_tests/with_test.py

@@ -11,12 +11,6 @@
 @pytest.mark.parametrize(
 		"src",
 		(
-				# TODO
-				#     'from threading import Lock\n'
-				#     'with (Lock() as l):\n'
-				#     '    pass',
-				#     id='simple named context manager',
-				# ),
 				pytest.param(
 						'with (\n'
 						'    open("wat")\n'
@@ -32,21 +26,39 @@
 						'     open("/tmp/y.py") as g: pass',
 						id="escaped newline",
 						),
-				# TODO
-				# pytest.param(
-				#     'with (open("/tmp/t.py") as f): pass',
-				#     id='single item',
-				# ),
-				# pytest.param(
-				#     'with (open("/tmp/t.py") as t, open("/tmp/y.py") as y): pass',
-				#     id='single line',
-				# ),
 				),
 		)
 def test_noop(src):
 	assert trailing_commas_hook(src, min_version=(2, 7)) == src
 
 
+@pytest.mark.parametrize(
+		"src",
+		(
+				pytest.param(
+						'from threading import Lock\n'
+						'with (Lock() as l):\n'
+						'    pass',
+						id="simple named context manager",
+						),
+				pytest.param(
+						'with (open("/tmp/t.py") as f): pass',
+						id="single item",
+						),
+				pytest.param(
+						'with (open("/tmp/t.py") as t, open("/tmp/y.py") as y): pass',
+						id="single line",
+						),
+				),
+		)
+def test_noop_or_syntaxerror(src):
+	if sys.version_info >= (3, 9):
+		assert trailing_commas_hook(src, min_version=(2, 7)) == src
+	else:
+		with pytest.raises(SyntaxError, match="invalid syntax"):
+			trailing_commas_hook(src, min_version=(2, 7))
+
+
 @pytest.mark.xfail(sys.version_info < (3, 9), reason="py39+")
 @pytest.mark.parametrize(
 		("src", "expected"),