Skip to content

Commit 07a11b0

Browse files
committed
Remove enable_inherit and disable_inherit, always use aiocontextvars==0.2.0
1 parent 52c51db commit 07a11b0

File tree

6 files changed

+2
-52
lines changed

6 files changed

+2
-52
lines changed

gino/engine.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,13 @@
44
import sys
55
import time
66

7+
from aiocontextvars import ContextVar
78
from sqlalchemy.engine import Engine, Connection
89
from sqlalchemy.sql import schema
910

1011
from .transaction import GinoTransaction
1112

1213

13-
if sys.version_info >= (3, 7):
14-
# noinspection PyPackageRequirements,PyUnresolvedReferences
15-
from contextvars import ContextVar
16-
else:
17-
# noinspection PyPackageRequirements
18-
from aiocontextvars import ContextVar # pragma: no cover
19-
20-
2114
class _BaseDBAPIConnection:
2215
_reset_agent = None
2316
gino_conn = None

gino/ext/aiohttp.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
# noinspection PyPackageRequirements
22
from aiohttp.web import HTTPNotFound, middleware
33
from sqlalchemy.engine.url import URL
4-
try:
5-
# noinspection PyPackageRequirements
6-
from aiocontextvars import enable_inherit, disable_inherit
7-
except ImportError:
8-
enable_inherit = disable_inherit = lambda loop: None
94

105
from ..api import Gino as _Gino, GinoExecutor as _Executor
116
from ..engine import GinoConnection as _Connection, GinoEngine as _Engine
@@ -114,15 +109,9 @@ async def _middleware(self, request, handler):
114109
def init_app(self, app):
115110
app['db'] = self
116111

117-
inherit_enabled = [False]
118-
119112
config = app['config'].get('gino', {})
120113

121114
async def before_server_start(app_):
122-
if config.setdefault('enable_inherit', True):
123-
enable_inherit(app_.loop)
124-
inherit_enabled[0] = True
125-
126115
if config.get('dsn'):
127116
dsn = config['dsn']
128117
else:
@@ -145,9 +134,6 @@ async def before_server_start(app_):
145134

146135
async def after_server_stop(app_):
147136
await self.pop_bind().close()
148-
if inherit_enabled[0]:
149-
disable_inherit(app_.loop)
150-
inherit_enabled[0] = False
151137

152138
app.on_startup.append(before_server_start)
153139
app.on_cleanup.append(after_server_stop)

gino/ext/quart.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@
55
# noinspection PyPackageRequirements
66
from quart.exceptions import NotFound
77
from sqlalchemy.engine.url import URL
8-
try:
9-
# noinspection PyPackageRequirements
10-
from aiocontextvars import enable_inherit, disable_inherit
11-
except ImportError:
12-
enable_inherit = disable_inherit = lambda loop: None
138

149
from ..api import Gino as _Gino, GinoExecutor as _Executor
1510
from ..engine import GinoConnection as _Connection, GinoEngine as _Engine
@@ -108,9 +103,6 @@ async def after_response(response):
108103

109104
@app.before_first_request
110105
async def before_first_request():
111-
if app.config.setdefault('DB_USE_CONNECTION_FOR_REQUEST', True):
112-
enable_inherit(asyncio.get_event_loop())
113-
114106
dsn = app.config.get('DB_DSN')
115107
if not dsn:
116108
dsn = URL(

gino/ext/sanic.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
# noinspection PyPackageRequirements
22
from sanic.exceptions import NotFound
33
from sqlalchemy.engine.url import URL
4-
try:
5-
# noinspection PyPackageRequirements
6-
from aiocontextvars import enable_inherit, disable_inherit
7-
except ImportError:
8-
enable_inherit = disable_inherit = lambda loop: None
94

105
from ..api import Gino as _Gino, GinoExecutor as _Executor
116
from ..engine import GinoConnection as _Connection, GinoEngine as _Engine
@@ -86,8 +81,6 @@ def __init__(self, app=None, *args, **kwargs):
8681
self.init_app(app)
8782

8883
def init_app(self, app):
89-
inherit_enabled = [False]
90-
9184
if app.config.setdefault('DB_USE_CONNECTION_FOR_REQUEST', True):
9285
@app.middleware('request')
9386
async def on_request(request):
@@ -101,10 +94,6 @@ async def on_response(request, _):
10194

10295
@app.listener('before_server_start')
10396
async def before_server_start(_, loop):
104-
if app.config.setdefault('DB_USE_CONNECTION_FOR_REQUEST', True):
105-
enable_inherit(loop)
106-
inherit_enabled[0] = True
107-
10897
if app.config.get('DB_DSN'):
10998
dsn = app.config.DB_DSN
11099
else:
@@ -128,9 +117,6 @@ async def before_server_start(_, loop):
128117
@app.listener('after_server_stop')
129118
async def after_server_stop(_, loop):
130119
await self.pop_bind().close()
131-
if inherit_enabled[0]:
132-
disable_inherit(loop)
133-
inherit_enabled[0] = False
134120

135121
async def first_or_404(self, *args, **kwargs):
136122
rv = await self.first(*args, **kwargs)

gino/ext/tornado.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,6 @@ async def get(self, uid):
164164

165165
from sqlalchemy.engine.url import URL
166166
from tornado.options import options as _options, define as _define
167-
try:
168-
# noinspection PyPackageRequirements
169-
from aiocontextvars import enable_inherit as _enable_inherit
170-
except ImportError:
171-
_enable_inherit = lambda _: None # NOQA
172167

173168
from ..api import Gino as _Gino, GinoExecutor as _Executor
174169
from ..engine import GinoConnection as _Connection, GinoEngine as _Engine
@@ -325,8 +320,6 @@ async def late_init(self, db: Gino, *, loop=None, options=_options):
325320
else:
326321
raise RuntimeError('AsyncIOLoop is required to run GINO')
327322

328-
_enable_inherit(asyncio_loop)
329-
330323
self.db = db
331324

332325
if 'dsn' in options:

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
asyncpg==0.17.0
22
SQLAlchemy==1.2.11
3-
aiocontextvars==0.2.0;python_version<"3.7"
3+
aiocontextvars==0.2.0

0 commit comments

Comments
 (0)