Skip to content

Commit f510822

Browse files
committed
fix bad test
* fixes #675
1 parent ac4febf commit f510822

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

tests/test_schema.py

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,40 @@
11
from enum import Enum
22

33
import pytest
4+
from asyncpg import UndefinedTableError
45

56
import gino
67
from gino.dialects.asyncpg import AsyncEnum
78

89
pytestmark = pytest.mark.asyncio
9-
db = gino.Gino()
1010

1111

1212
class MyEnum(Enum):
1313
ONE = "one"
1414
TWO = "two"
1515

1616

17-
class Blog(db.Model):
18-
__tablename__ = "s_blog"
19-
20-
id = db.Column(db.BigInteger(), primary_key=True)
21-
title = db.Column(db.Unicode(), index=True, comment="Title Comment")
22-
visits = db.Column(db.BigInteger(), default=0)
23-
comment_id = db.Column(db.ForeignKey("s_comment.id"))
24-
number = db.Column(db.Enum(MyEnum), nullable=False, default=MyEnum.TWO)
25-
number2 = db.Column(AsyncEnum(MyEnum), nullable=False, default=MyEnum.TWO)
26-
17+
async def test(engine, define=True):
18+
db = gino.Gino()
2719

28-
class Comment(db.Model):
29-
__tablename__ = "s_comment"
20+
class Blog(db.Model):
21+
__tablename__ = "s_blog"
3022

31-
id = db.Column(db.BigInteger(), primary_key=True)
32-
blog_id = db.Column(db.ForeignKey("s_blog.id", name="blog_id_fk"))
23+
id = db.Column(db.BigInteger(), primary_key=True)
24+
title = db.Column(db.Unicode(), index=True, comment="Title Comment")
25+
visits = db.Column(db.BigInteger(), default=0)
26+
comment_id = db.Column(db.ForeignKey("s_comment.id"))
27+
number = db.Column(db.Enum(MyEnum), nullable=False, default=MyEnum.TWO)
28+
number2 = db.Column(AsyncEnum(MyEnum), nullable=False, default=MyEnum.TWO)
3329

30+
class Comment(db.Model):
31+
__tablename__ = "s_comment"
3432

35-
blog_seq = db.Sequence("blog_seq", metadata=db, schema="schema_test")
33+
id = db.Column(db.BigInteger(), primary_key=True)
34+
blog_id = db.Column(db.ForeignKey("s_blog.id", name="blog_id_fk"))
3635

36+
blog_seq = db.Sequence("blog_seq", metadata=db, schema="schema_test")
3737

38-
async def test(engine, define=True):
3938
try:
4039
async with engine.acquire() as conn:
4140
assert not await engine.dialect.has_schema(conn, "schema_test")
@@ -78,6 +77,5 @@ class Comment2(db.Model):
7877

7978
async def test_no_alter(engine, mocker):
8079
engine.dialect.supports_alter = False
81-
warn = mocker.patch("warnings.warn")
82-
await test(engine, define=False)
83-
assert warn.called
80+
with pytest.raises(UndefinedTableError):
81+
await test(engine, define=False)

0 commit comments

Comments
 (0)