Skip to content

Commit 4eb47c8

Browse files
committed
test_untracked_memory_doesnt_increase_unfinished_thread_dealloc_in_main: A change in the GHA Runner Image version caused this test to break ONLY on Windows 3.14t; skip it.
It's unclear exactly what they changed that broke it, the operating system version is reported to be the same.
1 parent 53ac405 commit 4eb47c8

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

src/greenlet/tests/test_leaks.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
from . import TestCase
1717
from . import PY314
1818
from . import RUNNING_ON_FREETHREAD_BUILD
19+
from . import WIN
1920
from .leakcheck import fails_leakcheck
2021
from .leakcheck import ignores_leakcheck
2122
from .leakcheck import RUNNING_ON_MANYLINUX
@@ -456,6 +457,17 @@ def test_untracked_memory_doesnt_increase_unfinished_thread_dealloc_in_thread(se
456457
# Because the main greenlets from the background threads do not exit in a timely fashion,
457458
# we fail the object-based leakchecks.
458459
def test_untracked_memory_doesnt_increase_unfinished_thread_dealloc_in_main(self):
460+
# Between Feb 10 and Feb 20 2026, this test started failing on
461+
# Github Actions, windows 3.14t. With no relevant code changes on
462+
# our part. Both versions were 3.14.3 (same build). The only change
463+
# is the Github actions "Runner Image". The working one was version
464+
# 20260202.17.1, while the updated failing version was
465+
# 20260217.31.1. Both report the same version of the operating system
466+
# (Microsoft Windows Server 2025 10.0.26100).
467+
#
468+
# Reevaluate on future runner image releases.
469+
if WIN and RUNNING_ON_FREETHREAD_BUILD and PY314:
470+
self.skipTest("Windows 3.14t appears to leak. No other platform does.")
459471
self._check_untracked_memory_thread(deallocate_in_thread=False)
460472

461473
if __name__ == '__main__':

0 commit comments

Comments
 (0)