Merge pull request #1212 from Kriechi/fix-467

use Settings equality in tests

Author: Kriechi

test/test_h2_upgrade.py

@@ -278,7 +278,7 @@ def test_client_settings_are_applied(self, frame_factory):
         # start of the connection, do not agree on their initial settings
         # state.
         assert (
-            client.local_settings._settings != server.remote_settings._settings
+            client.local_settings != server.remote_settings
         )
 
         # Get the client header data and pass it to the server.
@@ -297,10 +297,6 @@ def test_client_settings_are_applied(self, frame_factory):
         )
         assert server.data_to_send() == expected_frame.serialize()
 
-        # We violate abstraction layers here, but I don't think defining __eq__
-        # for this is worth it. In this case, both the client and server should
-        # agree that these settings have been ACK'd, so their underlying
-        # dictionaries should be identical.
         assert (
-            client.local_settings._settings == server.remote_settings._settings
+            client.local_settings == server.remote_settings
         )