Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Commit 1512d62

Browse files
committed
Document the odd SETTINGS behaviour on the window.
Right now we handle a window resize a bit strangely. For the moment this interface is probably OK, but it won't stay OK forever.
1 parent dbbbf61 commit 1512d62

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

hyper/http20/window.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,11 @@ def increase_window_size(self, frame_size):
6767
Note that this method is called before the window size is decremented
6868
as a result of the frame being handled.
6969
70-
:param frame_size: The size of the received frame.
70+
:param frame_size: The size of the received frame. Note that this *may*
71+
be zero. When this parameter is zero, it's possible that a
72+
WINDOWUPDATE frame may want to be emitted anyway. A zero-length frame
73+
size is usually associated with a change in the size of the receive
74+
window due to a SETTINGS frame.
7175
:returns: The amount to increase the receive window by. Return zero if
7276
the window should not be increased.
7377
"""

0 commit comments

Comments
 (0)