Add http upgrade headers only sent once test

Author: fredthomsen

hyper/http11/connection.py

@@ -69,6 +69,7 @@ def __init__(self, host, port=None, secure=None, ssl_context=None,
         else:
             self.secure = False
 
+        # only send http upgrade headers for non-secure connection
         self._send_http_upgrade = not self.secure
 
         self.ssl_context = ssl_context
@@ -133,7 +134,7 @@ def request(self, method, url, body=None, headers={}):
 
         if self._sock is None:
             self.connect()
-       
+
         if(self._send_http_upgrade):
             self._add_upgrade_headers(headers)
             self._send_http_upgrade = False

test/test_http11.py

@@ -334,6 +334,24 @@ def body():
                 body=body()
             )
 
+    def test_http_upgrade_headers_only_sent_once(self):
+        c = HTTP11Connection('httpbin.org')
+        c._sock = sock = DummySocket()
+
+        c.request('GET', '/get', headers={'User-Agent': 'hyper'})
+
+        sock.queue = []
+        c.request('GET', '/get', headers={'User-Agent': 'hyper'})
+        received = b''.join(sock.queue)
+
+        expected = (
+            b"GET /get HTTP/1.1\r\n"
+            b"User-Agent: hyper\r\n"
+            b"host: httpbin.org\r\n"
+            b"\r\n"
+        )
+
+        assert received == expected
 
 class TestHTTP11Response(object):
     def test_short_circuit_read(self):