Convert header name to native string before checking

Author: irvind

hyper/common/util.py

@@ -7,6 +7,7 @@
 """
 from hyper.compat import unicode, bytes, imap
 from ..packages.rfc3986.uri import URIReference
+from ..compat import is_py3
 import re
 
 
@@ -50,3 +51,10 @@ def to_host_port_tuple(host_port_str, default_port=80):
         port = int(uri.port)
 
     return (host, port)
+
+
+def to_native_string(string, encoding='utf-8'):
+    if isinstance(string, str):
+        return string
+
+    return string.decode(encoding) if is_py3 else string.encode(encoding)

hyper/http20/connection.py

@@ -9,7 +9,7 @@
 from ..common.exceptions import ConnectionResetError
 from ..common.bufsocket import BufferedSocket
 from ..common.headers import HTTPHeaderMap
-from ..common.util import to_host_port_tuple
+from ..common.util import to_host_port_tuple, to_native_string
 from ..packages.hyperframe.frame import (
     FRAMES, DataFrame, HeadersFrame, PushPromiseFrame, RstStreamFrame,
     SettingsFrame, Frame, WindowUpdateFrame, GoAwayFrame, PingFrame,
@@ -172,7 +172,8 @@ def request(self, method, url, body=None, headers={}):
 
         default_headers = (':method', ':scheme', ':authority', ':path')
         for name, value in headers.items():
-            self.putheader(name, value, stream_id, replace=name in default_headers)
+            is_default = to_native_string(name) in default_headers
+            self.putheader(name, value, stream_id, replace=is_default)
 
         # Convert the body to bytes if needed.
         if isinstance(body, str):