Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Commit 1ac2e20

Browse files
committed
We MUST drain the socket before closing.
1 parent 4f20938 commit 1ac2e20

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

test/test_integration_http11.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,16 @@ class TestHyperH11Integration(SocketLevelTest):
2626
def test_basic_request_response(self):
2727
self.set_up()
2828

29-
data = []
3029
send_event = threading.Event()
3130

3231
def socket_handler(listener):
3332
sock = listener.accept()[0]
3433

3534
# We should get the initial request.
36-
data.append(sock.recv(65535))
35+
data = b''
36+
while not data.endswith(b'\r\n\r\n'):
37+
data += sock.recv(65535)
38+
3739
send_event.wait()
3840

3941
# We need to send back a response.
@@ -66,14 +68,16 @@ def socket_handler(listener):
6668
def test_closing_response(self):
6769
self.set_up()
6870

69-
data = []
7071
send_event = threading.Event()
7172

7273
def socket_handler(listener):
7374
sock = listener.accept()[0]
7475

7576
# We should get the initial request.
76-
data.append(sock.recv(65535))
77+
data = b''
78+
while not data.endswith(b'\r\n\r\n'):
79+
data += sock.recv(65535)
80+
7781
send_event.wait()
7882

7983
# We need to send back a response.
@@ -114,14 +118,16 @@ def socket_handler(listener):
114118
def test_response_with_body(self):
115119
self.set_up()
116120

117-
data = []
118121
send_event = threading.Event()
119122

120123
def socket_handler(listener):
121124
sock = listener.accept()[0]
122125

123126
# We should get the initial request.
124-
data.append(sock.recv(65535))
127+
data = b''
128+
while not data.endswith(b'\r\n\r\n'):
129+
data += sock.recv(65535)
130+
125131
send_event.wait()
126132

127133
# We need to send back a response.

0 commit comments

Comments
 (0)