Don't emit RST_STREAM frame on data exhaustion

Fixes #149.

Author: Lukasa

HISTORY.rst

@@ -12,10 +12,12 @@ dev
 *Bugfixes*
 
 - Prevent hyper from emitting oversized frames. Thanks to @jdecuyper!
+- Prevent hyper from emitting RST_STREAM frames whenever it finishes consuming
+  a stream.
 
 *Software Updates*
 
-- Updated hyperframe to version 1.1.0.
+- Updated hyperframe to version 1.1.1.
 
 0.4.0 (2015-06-21)
 ------------------

hyper/http20/connection.py

@@ -500,7 +500,10 @@ def _close_stream(self, stream_id, error_code=None):
         """
         Called by a stream when it would like to be 'closed'.
         """
-        self._send_rst_frame(stream_id, error_code)
+        # Graceful shutdown of streams involves not emitting an error code
+        # at all.
+        if error_code:
+            self._send_rst_frame(stream_id, error_code)
 
     def _send_cb(self, frame, tolerate_peer_gone=False):
         """
@@ -519,6 +522,9 @@ def _send_cb(self, frame, tolerate_peer_gone=False):
 
             self._out_flow_control_window -= len(frame.data)
 
+        if frame.type == RstStreamFrame.type:
+            import pdb; pdb.set_trace()
+
         data = frame.serialize()
 
         max_frame_size = self._settings[SettingsFrame.SETTINGS_MAX_FRAME_SIZE]