Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Commit 98f4074

Browse files
committed
Refactor out the HTTP/2.0 preamble in tests.
1 parent 5c87a88 commit 98f4074

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

test/test_integration.py

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,15 @@ def build_headers_frame(headers):
4242
return f
4343

4444

45+
def receive_preamble(sock):
46+
# Receive the HTTP/2.0 'preamble'.
47+
sock.recv(65535)
48+
sock.recv(65535)
49+
sock.send(SettingsFrame(0).serialize())
50+
sock.recv(65535)
51+
return
52+
53+
4554
class TestHyperIntegration(SocketLevelTest):
4655
def test_connection_string(self):
4756
self.set_up()
@@ -226,10 +235,7 @@ def socket_handler(listener):
226235

227236
# We're going to get the two messages for the connection open, then
228237
# a headers frame.
229-
sock.recv(65535)
230-
sock.recv(65535)
231-
sock.send(SettingsFrame(0).serialize())
232-
sock.recv(65535)
238+
receive_preamble(sock)
233239

234240
# Now, send the headers for the response.
235241
f = build_headers_frame([(':status', '200')])
@@ -264,10 +270,7 @@ def socket_handler(listener):
264270

265271
# We get two messages for the connection open and then a HEADERS
266272
# frame.
267-
sock.recv(65535)
268-
sock.recv(65535)
269-
sock.send(SettingsFrame(0).serialize())
270-
sock.recv(65535)
273+
receive_preamble(sock)
271274

272275
# Now, send the headers for the response. This response has no body.
273276
f = build_headers_frame([(':status', '204'), ('Content-Length', '0')])
@@ -307,10 +310,7 @@ def socket_handler(listener):
307310
sock = listener.accept()[0]
308311

309312
# Do the handshake: conn header, settings, send settings, recv ack.
310-
sock.recv(65535)
311-
sock.recv(65535)
312-
sock.send(SettingsFrame(0).serialize())
313-
sock.recv(65535)
313+
receive_preamble(sock)
314314

315315
# Now expect some data. One headers frame.
316316
data.append(sock.recv(65535))
@@ -351,10 +351,7 @@ def socket_handler(listener):
351351
sock = listener.accept()[0]
352352

353353
# Do the handshake: conn header, settings, send settings, recv ack.
354-
sock.recv(65535)
355-
sock.recv(65535)
356-
sock.send(SettingsFrame(0).serialize())
357-
sock.recv(65535)
354+
receive_preamble(sock)
358355

359356
# Now expect some data. One headers frame and one data frame.
360357
data.append(sock.recv(65535))

0 commit comments

Comments
 (0)