Set mypy show_error_codes and change type-ignore to specific error codes

This makes it easier to see what is being ignored, and doesn't ignore
any unrelated error that might come up in the line.

Author: bluetech

compliance/run-autobahn-tests.py

@@ -10,7 +10,7 @@
 import subprocess
 import sys
 import time
-from typing import Any, Dict, List, Tuple
+from typing import Dict, List, Tuple
 
 PORT = 8642
 
@@ -62,7 +62,7 @@
 }
 
 
-def say(*args: Any) -> None:  # type: ignore
+def say(*args: object) -> None:
     print("run-autobahn-tests.py:", *args)
 
 

setup.cfg

@@ -41,6 +41,7 @@ disallow_untyped_decorators = True
 disallow_untyped_defs = True
 implicit_reexport = False
 no_implicit_optional = True
+show_error_codes = True
 strict_equality = True
 strict_optional = True
 warn_redundant_casts = True

src/wsproto/events.py

@@ -54,7 +54,7 @@ class Request(Event):
 
     host: str
     target: str
-    extensions: Union[Sequence[Extension], Sequence[str]] = field(  # type: ignore
+    extensions: Union[Sequence[Extension], Sequence[str]] = field(  # type: ignore[assignment]
         default_factory=list
     )
     extra_headers: Headers = field(default_factory=list)

src/wsproto/handshake.py

@@ -344,15 +344,18 @@ def _initiate_connection(self, request: Request) -> bytes:
             )
 
         if request.extensions:
-            offers = {e.name: e.offer() for e in request.extensions}  # type: ignore
+            offers: Dict[str, Union[str, bool]] = {}
+            for e in request.extensions:
+                assert isinstance(e, Extension)
+                offers[e.name] = e.offer()
             extensions = []
             for name, params in offers.items():
-                name = name.encode("ascii")
+                bname = name.encode("ascii")
                 if isinstance(params, bool):
                     if params:
-                        extensions.append(name)
+                        extensions.append(bname)
                 else:
-                    extensions.append(b"%s; %s" % (name, params.encode("ascii")))
+                    extensions.append(b"%s; %s" % (bname, params.encode("ascii")))
             if extensions:
                 headers.append((b"Sec-WebSocket-Extensions", b", ".join(extensions)))
 

test/test_connection.py

@@ -65,7 +65,7 @@ def test_closure(client_sends: bool, code: CloseReason, reason: str) -> None:
     assert event.code is code
     assert event.reason == reason
 
-    assert remote.state is ConnectionState.CLOSED  # type: ignore
+    assert remote.state is ConnectionState.CLOSED  # type: ignore[comparison-overlap]
     assert local.state is ConnectionState.CLOSED
 
 

test/test_extensions.py

@@ -22,23 +22,23 @@ def test_finalize(self) -> None:
 
     def test_frame_inbound_header(self) -> None:
         ext = wpext.Extension()
-        result = ext.frame_inbound_header(None, None, None, None)  # type: ignore
+        result = ext.frame_inbound_header(None, None, None, None)  # type: ignore[arg-type]
         assert result == fp.RsvBits(False, False, False)
 
     def test_frame_inbound_payload_data(self) -> None:
         ext = wpext.Extension()
         data = b""
-        assert ext.frame_inbound_payload_data(None, data) == data  # type: ignore
+        assert ext.frame_inbound_payload_data(None, data) == data  # type: ignore[arg-type]
 
     def test_frame_inbound_complete(self) -> None:
         ext = wpext.Extension()
-        assert ext.frame_inbound_complete(None, None) is None  # type: ignore
+        assert ext.frame_inbound_complete(None, None) is None  # type: ignore[arg-type]
 
     def test_frame_outbound(self) -> None:
         ext = wpext.Extension()
         rsv = fp.RsvBits(True, True, True)
         data = b""
-        assert ext.frame_outbound(None, None, rsv, data, None) == (  # type: ignore
+        assert ext.frame_outbound(None, None, rsv, data, None) == (  # type: ignore[arg-type]
             rsv,
             data,
         )