Resolve typing issues with referencing+mypy

Also setup a pyright tox environment for testing and usage.

Author: sirosen

src/check_jsonschema/parsers/__init__.py

@@ -65,7 +65,7 @@ def __init__(
             }
 
     def get(
-        self, path: pathlib.Path, default_filetype: str
+        self, path: pathlib.Path | str, default_filetype: str
     ) -> t.Callable[[t.BinaryIO], t.Any]:
         filetype = path_to_type(path, default_type=default_filetype)
 

src/check_jsonschema/schema_loader/resolver.py

@@ -6,7 +6,7 @@
 
 import referencing
 import requests
-from referencing.jsonschema import DRAFT202012
+from referencing.jsonschema import DRAFT202012, Schema
 
 from ..parsers import ParserSet
 from ..utils import filename2path
@@ -18,7 +18,9 @@ def make_reference_registry(
     schema_resource = referencing.Resource.from_contents(
         schema, default_specification=DRAFT202012
     )
-    registry = referencing.Registry(
+    # mypy does not recognize that Registry is an `attrs` class and has `retrieve` as an
+    # argument to its implicit initializer
+    registry: referencing.Registry = referencing.Registry(  # type: ignore[call-arg]
         retrieve=create_retrieve_callable(parsers, schema_uri)
     )
 
@@ -34,8 +36,8 @@ def make_reference_registry(
 
 def create_retrieve_callable(
     parser_set: ParserSet, schema_uri: str | None
-) -> t.Callable[[str], referencing.Resource]:
-    def get_local_file(uri: str):
+) -> t.Callable[[str], referencing.Resource[Schema]]:
+    def get_local_file(uri: str) -> t.Any:
         path = pathlib.Path(uri)
         if not path.is_absolute():
             if schema_uri is None:
@@ -48,7 +50,7 @@ def get_local_file(uri: str):
             path = schema_path.parent / path
         return parser_set.parse_file(path, "json")
 
-    def retrieve_reference(uri: str) -> referencing.Resource:
+    def retrieve_reference(uri: str) -> referencing.Resource[Schema]:
         scheme = urllib.parse.urlsplit(uri).scheme
         if scheme in ("http", "https"):
             data = requests.get(uri, stream=True)

tox.ini

@@ -54,6 +54,13 @@ deps = mypy
        click==8.1.3
 commands = mypy src/ {posargs}
 
+[testenv:pyright]
+description = "check type annotations with pyright"
+deps = pyright
+       types-jsonschema
+       types-requests
+commands = pyright src/ {posargs}
+
 [testenv:docs]
 description = "build docs with sphinx"
 basepython = python3.10