Skip to content

Commit d651b8d

Browse files
committed
Comment for recursion
1 parent 0f933d3 commit d651b8d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/hypothesis_jsonschema/_canonicalise.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -858,6 +858,10 @@ def merged(schemas: List[Any]) -> Optional[Schema]:
858858
elif out[k] != v and k in ALL_KEYWORDS:
859859
# If non-validation keys like `title` or `description` don't match,
860860
# that doesn't really matter and we'll just go with first we saw.
861+
#
862+
# TODO: note that this is NOT TRUE in the case of recursive references,
863+
# where we might change the value at some location that a reference
864+
# still points to!
861865
return None
862866
out = canonicalish(out)
863867
if out == FALSEY:

0 commit comments

Comments
 (0)