Skip to content

Commit ed887ce

Browse files
committed
Unskip more passing tests.
1 parent 53694e7 commit ed887ce

File tree

1 file changed

+16
-86
lines changed

1 file changed

+16
-86
lines changed

jsonschema/tests/test_jsonschema_test_suite.py

Lines changed: 16 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,18 @@ def missing_date_fromisoformat(test):
110110
def missing_date_fromisoformat(test):
111111
return
112112

113-
allowed_leading_zeros = skip(
114-
message="This behavior is optional (and Python allows it)",
115-
subject="ipv4",
116-
description=(
117-
"leading zeroes should be rejected, as they are treated as octals"
118-
),
119-
)
113+
if sys.version_info < (3, 9):
114+
message = "Rejecting leading zeros is 3.9+"
115+
allowed_leading_zeros = skip(
116+
message=message,
117+
subject="ipv4",
118+
description=(
119+
"leading zeroes should be rejected, as they are treated as octals"
120+
),
121+
)
122+
else:
123+
def allowed_leading_zeros(test):
124+
return
120125

121126

122127
def leap_second(test):
@@ -147,6 +152,9 @@ def leap_second(test):
147152
or skip(
148153
message=bug(371),
149154
subject="ref",
155+
description=(
156+
"$ref resolves to /definitions/foo, data does not validate"
157+
),
150158
case_description=(
151159
"$ref prevents a sibling id from changing the base uri"
152160
),
@@ -228,7 +236,7 @@ def leap_second(test):
228236
DRAFT6.optional_tests_of(name="bignum"),
229237
DRAFT6.optional_tests_of(name="float-overflow"),
230238
DRAFT6.optional_tests_of(name="non-bmp-regex"),
231-
DRAFT7.optional_tests_of(name="unicode"),
239+
DRAFT6.optional_tests_of(name="unicode"),
232240
Validator=Draft6Validator,
233241
format_checker=draft6_format_checker,
234242
skip=lambda test: (
@@ -237,11 +245,6 @@ def leap_second(test):
237245
or allowed_leading_zeros(test)
238246
or missing_format(draft6_format_checker)(test)
239247
or complex_email_validation(test)
240-
or skip(
241-
message=bug(),
242-
subject="ref",
243-
case_description="Recursive references between schemas",
244-
)(test)
245248
or skip(
246249
message=bug(371),
247250
subject="ref",
@@ -262,40 +265,6 @@ def leap_second(test):
262265
"base URI change in subschema"
263266
),
264267
)(test)
265-
or skip(
266-
message=bug(371),
267-
subject="ref",
268-
case_description="refs with relative uris and defs",
269-
)(test)
270-
or skip(
271-
message=bug(371),
272-
subject="ref",
273-
case_description="relative refs with absolute uris and defs",
274-
)(test)
275-
or skip(
276-
message=bug(371),
277-
subject="ref",
278-
case_description=(
279-
"$ref prevents a sibling $id from changing the base uri"
280-
),
281-
)(test)
282-
or skip(
283-
message=bug(371),
284-
subject="id",
285-
description="match $ref to id",
286-
)(test)
287-
or skip(
288-
message=bug(371),
289-
subject="id",
290-
description="no match on enum or $ref to id",
291-
)(test)
292-
or skip(
293-
message=bug(),
294-
subject="unknownKeyword",
295-
case_description=(
296-
"$id inside an unknown keyword is not a real identifier"
297-
),
298-
)(test)
299268
or skip(
300269
message=bug(),
301270
subject="refRemote",
@@ -322,11 +291,6 @@ def leap_second(test):
322291
or leap_second(test)
323292
or missing_format(draft7_format_checker)(test)
324293
or complex_email_validation(test)
325-
or skip(
326-
message=bug(),
327-
subject="ref",
328-
case_description="Recursive references between schemas",
329-
)(test)
330294
or skip(
331295
message=bug(371),
332296
subject="ref",
@@ -347,40 +311,6 @@ def leap_second(test):
347311
"base URI change in subschema"
348312
),
349313
)(test)
350-
or skip(
351-
message=bug(371),
352-
subject="ref",
353-
case_description="refs with relative uris and defs",
354-
)(test)
355-
or skip(
356-
message=bug(371),
357-
subject="ref",
358-
case_description="relative refs with absolute uris and defs",
359-
)(test)
360-
or skip(
361-
message=bug(371),
362-
subject="ref",
363-
case_description=(
364-
"$ref prevents a sibling $id from changing the base uri"
365-
),
366-
)(test)
367-
or skip(
368-
message=bug(371),
369-
subject="id",
370-
description="match $ref to id",
371-
)(test)
372-
or skip(
373-
message=bug(371),
374-
subject="id",
375-
description="no match on enum or $ref to id",
376-
)(test)
377-
or skip(
378-
message=bug(),
379-
subject="unknownKeyword",
380-
case_description=(
381-
"$id inside an unknown keyword is not a real identifier"
382-
),
383-
)(test)
384314
or skip(
385315
message=bug(),
386316
subject="refRemote",

0 commit comments

Comments
 (0)