Skip to content

Commit ff95ee4

Browse files
committed
Skip the tests which tickle known bugs.
1 parent b59060c commit ff95ee4

File tree

1 file changed

+56
-8
lines changed

1 file changed

+56
-8
lines changed

jsonschema/tests/test_jsonschema_test_suite.py

Lines changed: 56 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ def leap_second(test):
159159
or skip(
160160
message=bug(371),
161161
subject="ref",
162-
description=(
163-
"$ref resolves to /definitions/foo, data does not validate"
164-
),
165162
case_description=(
166163
"$ref prevents a sibling id from changing the base uri"
167164
),
@@ -176,7 +173,6 @@ def leap_second(test):
176173
DRAFT4.optional_tests_of(name="bignum"),
177174
DRAFT4.optional_tests_of(name="float-overflow"),
178175
DRAFT4.optional_tests_of(name="non-bmp-regex"),
179-
DRAFT4.optional_tests_of(name="unicode"),
180176
DRAFT4.optional_tests_of(name="zeroTerminatedFloats"),
181177
Validator=Draft4Validator,
182178
format_checker=draft4_format_checker,
@@ -220,6 +216,14 @@ def leap_second(test):
220216
subject="refRemote",
221217
case_description="base URI change - change folder in subschema",
222218
)(test)
219+
or skip(
220+
message=bug(),
221+
subject="ref",
222+
case_description=(
223+
"id must be resolved against nearest parent, "
224+
"not just immediate parent"
225+
),
226+
)(test)
223227
),
224228
)
225229

@@ -230,7 +234,6 @@ def leap_second(test):
230234
DRAFT6.optional_tests_of(name="bignum"),
231235
DRAFT6.optional_tests_of(name="float-overflow"),
232236
DRAFT6.optional_tests_of(name="non-bmp-regex"),
233-
DRAFT6.optional_tests_of(name="unicode"),
234237
Validator=Draft6Validator,
235238
format_checker=draft6_format_checker,
236239
skip=lambda test: (
@@ -251,6 +254,13 @@ def leap_second(test):
251254
subject="refRemote",
252255
case_description="base URI change - change folder in subschema",
253256
)(test)
257+
or skip(
258+
message=bug(371),
259+
subject="ref",
260+
case_description=(
261+
"$ref prevents a sibling $id from changing the base uri"
262+
),
263+
)(test)
254264
),
255265
)
256266

@@ -262,7 +272,6 @@ def leap_second(test):
262272
DRAFT7.optional_tests_of(name="content"),
263273
DRAFT7.optional_tests_of(name="float-overflow"),
264274
DRAFT7.optional_tests_of(name="non-bmp-regex"),
265-
DRAFT7.optional_tests_of(name="unicode"),
266275
Validator=Draft7Validator,
267276
format_checker=draft7_format_checker,
268277
skip=lambda test: (
@@ -284,6 +293,21 @@ def leap_second(test):
284293
subject="refRemote",
285294
case_description="base URI change - change folder in subschema",
286295
)(test)
296+
or skip(
297+
message=bug(371),
298+
subject="ref",
299+
case_description=(
300+
"$ref prevents a sibling $id from changing the base uri"
301+
),
302+
)(test)
303+
or skip(
304+
message=bug(),
305+
subject="ref",
306+
case_description=(
307+
"$id must be resolved against nearest parent, "
308+
"not just immediate parent"
309+
),
310+
)(test)
287311
or skip(
288312
message=bug(593),
289313
subject="content",
@@ -316,7 +340,6 @@ def leap_second(test):
316340
DRAFT201909.optional_tests_of(name="float-overflow"),
317341
DRAFT201909.optional_tests_of(name="non-bmp-regex"),
318342
DRAFT201909.optional_tests_of(name="refOfUnknownKeyword"),
319-
DRAFT201909.optional_tests_of(name="unicode"),
320343
Validator=Draft201909Validator,
321344
skip=lambda test: (
322345
skip(
@@ -327,6 +350,19 @@ def leap_second(test):
327350
message="dynamicRef support isn't working yet.",
328351
subject="recursiveRef",
329352
)(test)
353+
or skip(
354+
message="These tests depends on dynamicRef working.",
355+
subject="anchor",
356+
case_description="same $anchor with different base uri",
357+
)(test)
358+
or skip(
359+
message=bug(),
360+
subject="ref",
361+
case_description=(
362+
"$id must be resolved against nearest parent, "
363+
"not just immediate parent"
364+
),
365+
)(test)
330366
),
331367
)
332368

@@ -351,7 +387,6 @@ def leap_second(test):
351387
DRAFT202012.optional_tests_of(name="float-overflow"),
352388
DRAFT202012.optional_tests_of(name="non-bmp-regex"),
353389
DRAFT202012.optional_tests_of(name="refOfUnknownKeyword"),
354-
DRAFT202012.optional_tests_of(name="unicode"),
355390
Validator=Draft202012Validator,
356391
skip=lambda test: (
357392
narrow_unicode_build(test)
@@ -363,6 +398,19 @@ def leap_second(test):
363398
message="These tests depends on dynamicRef working.",
364399
subject="defs",
365400
)(test)
401+
or skip(
402+
message="These tests depends on dynamicRef working.",
403+
subject="anchor",
404+
case_description="same $anchor with different base uri",
405+
)(test)
406+
or skip(
407+
message=bug(),
408+
subject="ref",
409+
case_description=(
410+
"$id must be resolved against nearest parent, "
411+
"not just immediate parent"
412+
),
413+
)(test)
366414
),
367415
)
368416

0 commit comments

Comments
 (0)