Missing options that can be set on the client?

[doolio]

python-lsp-black/pylsp_black/plugin.py

Lines 50 to 63 in 27200ee

	def pylsp_settings():
	"""Configuration options that can be set on the client."""
	return {
	"plugins": {
	"black": {
	"enabled": True,
	"line_length": 88,
	"preview": False,
	"cache_config": False,
	},
	"yapf": {"enabled": False},
	"autopep8": {"enabled": False},
	}
	}

Should skip_magic_trailing_comma and skip_string_normalization be included here?

[haplo]

They are included in

python-lsp-black/pylsp_black/plugin.py

Lines 94 to 95 in 27200ee

	string_normalization=not config["skip_string_normalization"],
	magic_trailing_comma=not config["skip_magic_trailing_comma"],

when black is actually called. I don't see a benefit to have it in two places, if anything we maybe should remove other things from pylsp_settings, like line_length and preview.

[doolio]

if anything we maybe should remove other things from pylsp_settings, like line_length and preview.

Whatever you feel is best though having them all defined under pylsp_settings makes it obvious (to me as a beginner) what settings are available. (I'm thinking in respect of keeping this gist up to date.) The various plugin implementations don't seem to be standardised which is unfortunate.