Add Python 3.8 support for rope_implementations

Author: smheidrich

pylsp/plugins/rope_implementation.py

@@ -2,7 +2,7 @@
 # Copyright 2021- Python Language Server Contributors.
 import logging
 import os
-from typing import Any
+from typing import Any, Dict, Tuple
 
 from rope.base.project import Project
 from rope.base.resources import Resource
@@ -42,7 +42,7 @@ def pylsp_implementations(config, workspace, document, position):
 
 def _rope_location_to_range(
     location: Location, rope_project: Project
-) -> dict[str, Any]:
+) -> Dict[str, Any]:
     # NOTE: This assumes the result is confined to a single line, which should
     # always be the case here because Python doesn't allow splitting up
     # identifiers across more than one line.
@@ -56,8 +56,8 @@ def _rope_location_to_range(
 
 
 def _rope_region_to_columns(
-    offsets: tuple[int, int], line: int, rope_resource: Resource, rope_project: Project
-) -> tuple[int, int]:
+    offsets: Tuple[int, int], line: int, rope_resource: Resource, rope_project: Project
+) -> Tuple[int, int]:
     """
     Convert pair of offsets from start of file to columns within line.
 

test/plugins/test_implementations.py

@@ -1,8 +1,7 @@
 # Copyright 2017-2020 Palantir Technologies, Inc.
 # Copyright 2021- Python Language Server Contributors.
 
-from collections.abc import Iterable
-from importlib.resources import as_file, files
+import test
 from pathlib import Path
 
 import pytest
@@ -21,9 +20,10 @@
 # An alternative to using real files would be `unittest.mock.patch`, but that
 # ends up being more trouble than it's worth...
 @pytest.fixture
-def examples_dir_path() -> Iterable[Path]:
-    with as_file(files("test.data.implementations_examples")) as path:
-        yield path
+def examples_dir_path() -> Path:
+    # In Python 3.12+, this should be obtained using `importlib.resources`,
+    # but as we need to support older versions, we do it the hacky way:
+    return Path(test.__file__).parent / "data/implementations_examples"
 
 
 @pytest.fixture