Made main more testable, simplified unit tests

Author: venthur

openapi_spec_validator/__main__.py

@@ -13,10 +13,10 @@
 )
 
 
-def main():
+def main(args=None):
     parser = argparse.ArgumentParser()
     parser.add_argument('filename', help="Absolute or relative path to file")
-    args = parser.parse_args()
+    args = parser.parse_args(args)
     filename = args.filename
     filename = os.path.abspath(filename)
     try:

tests/integration/test_main.py

@@ -1,22 +1,16 @@
-from unittest import mock
+import pytest
 
 from openapi_spec_validator.__main__ import main
 
 
-@mock.patch('openapi_spec_validator.__main__.sys')
-def test_nonexisting_file(mock_sys):
-    """Calling with non-existing file should sys.exit."""
-    # the first parameter is always the name of the program itself, so
-    # we can insert a dummy here
-    testargs = ['progname', 'i_dont_exist.yaml']
-    with mock.patch('sys.argv', testargs):
-        main()
-        assert mock_sys.exit.called
+def test_happy_path():
+    """No errors when calling with proper file."""
+    testargs = ['./tests/integration/data/v3.0/petstore.yaml']
+    main(testargs)
 
 
-@mock.patch('openapi_spec_validator.__main__.sys')
-def test_happy_path(mock_sys):
-    testargs = ['progname', './tests/integration/data/v3.0/petstore.yaml']
-    with mock.patch('sys.argv', testargs):
-        main()
-        assert not mock_sys.exit.called
+def test_nonexisting_file():
+    """Calling with non-existing file should sys.exit."""
+    testargs = ['i_dont_exist.yaml']
+    with pytest.raises(SystemExit):
+        main(testargs)