Adds support for hour, minute, second units in start_of()/end_of() methods.

Author: sdispater

CHANGELOG.md

@@ -8,6 +8,7 @@
 - Added a `Time` class.
 - Added a `remaining_days` property to the `Interval` class.
 - Added a `in_timestamp` property to the `Pendulum` class to retrieve the behavior of the now deprecated `timestamp` property.
+- `start_of()`/`end_of()` now supports `hour`, `minute` and `second` units.
 
 ### Changed
 
@@ -30,6 +31,7 @@
 - Accuracy of `Period` instances properties has been improved.
 - Accuracy for microseconds when initializing a Pendulum instance in some timezones has been fixed.
 - Periods are now serializable with `pickle`.
+- Fixed `minute_()`, `second_()` and `microsecond_()` setters changing the hour unit.
 
 
 ## [0.6.5] - 2016-10-31

pendulum/pendulum.py

@@ -44,6 +44,12 @@ class Pendulum(Date, datetime.datetime):
 
     _TRANSITION_RULE = Timezone.POST_TRANSITION
 
+    _MODIFIERS_VALID_UNITS = [
+        'second', 'minute', 'hour',
+        'day', 'week', 'month', 'year',
+        'decade', 'century'
+    ]
+
     @classmethod
     def _safe_create_datetime_zone(cls, obj):
         """
@@ -455,7 +461,7 @@ def microsecond_(self, microsecond):
         return self._setter(microsecond=microsecond)
 
     def _setter(self, **kwargs):
-        kwargs['tzinfo'] = None
+        kwargs['tzinfo'] = True
 
         return self._tz.convert(self.replace(**kwargs))
 
@@ -1291,6 +1297,9 @@ def start_of(self, unit):
         Returns a copy of the instance with the time reset
         with the following rules:
 
+        * second: microsecond set to 0
+        * minute: second and microsecond set to 0
+        * hour: minute, second and microsecond set to 0
         * day: time to 00:00:00
         * week: date to first day of the week and time to 00:00:00
         * month: date to first day of the month and time to 00:00:00
@@ -1313,6 +1322,9 @@ def end_of(self, unit):
         Returns a copy of the instance with the time reset
         with the following rules:
 
+        * second: microsecond set to 999999
+        * minute: second set to 59 and microsecond set to 999999
+        * hour: minute and second set to 59 and microsecond set to 999999
         * day: time to 23:59:59.999999
         * week: date to last day of the week and time to 23:59:59.999999
         * month: date to last day of the month and time to 23:59:59.999999
@@ -1330,6 +1342,54 @@ def end_of(self, unit):
 
         return getattr(self, '_end_of_%s' % unit)()
 
+    def _start_of_second(self):
+        """
+        Reset microseconds to 0.
+
+        :rtype: Pendulum
+        """
+        return self.microsecond_(0)
+
+    def _end_of_second(self):
+        """
+        Set microseconds to 999999.
+
+        :rtype: Pendulum
+        """
+        return self.microsecond_(999999)
+
+    def _start_of_minute(self):
+        """
+        Reset seconds and microseconds to 0.
+
+        :rtype: Pendulum
+        """
+        return self.replace(second=0, microsecond=0)
+
+    def _end_of_minute(self):
+        """
+        Set seconds to 59 and microseconds to 999999.
+
+        :rtype: Pendulum
+        """
+        return self.replace(second=59, microsecond=999999)
+
+    def _start_of_hour(self):
+        """
+        Reset minutes, seconds and microseconds to 0.
+
+        :rtype: Pendulum
+        """
+        return self.replace(minute=0, second=0, microsecond=0)
+
+    def _end_of_hour(self):
+        """
+        Set minutes and seconds to 59 and microseconds to 999999.
+
+        :rtype: Pendulum
+        """
+        return self.replace(minute=59, second=59, microsecond=999999)
+
     def _start_of_day(self):
         """
         Reset the time to 00:00:00

tests/pendulum_tests/test_fluent_setters.py

@@ -58,6 +58,11 @@ def test_fluid_microsecond_setter(self):
         self.assertEqual(987654, new.microsecond)
         self.assertEqual(123456, d.microsecond)
 
+    def test_fluid_setter_keeps_timezone(self):
+        d = Pendulum.create(2016, 7, 2, 0, 41, 20, 123456, tz='Europe/Paris')
+        new = d.microsecond_(987654)
+        self.assertPendulum(new, 2016, 7, 2, 0, 41, 20, 987654)
+
     def test_fluid_timezone_setter(self):
         d = Pendulum.create(2016, 7, 2, 0, 41, 20)
         new = d.timezone_('Europe/Paris')

tests/pendulum_tests/test_start_end_of.py

@@ -7,6 +7,42 @@
 
 class StartEndOfTest(AbstractTestCase):
 
+    def test_start_of_second(self):
+        d = Pendulum.now()
+        new = d.start_of('second')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, d.minute, d.second, 0)
+
+    def test_end_of_second(self):
+        d = Pendulum.now()
+        new = d.end_of('second')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, d.minute, d.second, 999999)
+
+    def test_start_of_minute(self):
+        d = Pendulum.now()
+        new = d.start_of('minute')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, d.minute, 0, 0)
+
+    def test_end_of_minute(self):
+        d = Pendulum.now()
+        new = d.end_of('minute')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, d.minute, 59, 999999)
+
+    def test_start_of_hour(self):
+        d = Pendulum.now()
+        new = d.start_of('hour')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, 0, 0, 0)
+
+    def test_end_of_hour(self):
+        d = Pendulum.now()
+        new = d.end_of('hour')
+        self.assertIsInstanceOfPendulum(new)
+        self.assertPendulum(new, d.year, d.month, d.day, d.hour, 59, 59, 999999)
+
     def test_start_of_day(self):
         d = Pendulum.now()
         new = d.start_of('day')