Skip to content

Commit 9e08ea6

Browse files
asrenzosdispater
authored andcommitted
Fixing missing parentheses in method day_of_year (#89)
* Fixing missing parentheses in method day_of_year * Adding a simple unit test for day_of_year (leap or not) * Adding a simple unit test for day_of_year (leap or not) * Moving tests to the right place and using last day of year
1 parent f30bd40 commit 9e08ea6

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

pendulum/date.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,11 @@ def day_of_year(self):
137137
138138
:rtype: int
139139
"""
140-
k = 1 if self.is_leap_year else 2
140+
k = 1 if self.is_leap_year() else 2
141141

142142
return (
143143
(275 * self.month) // 9
144-
- k * (self.month + 9) // 12
144+
- k * ((self.month + 9) // 12)
145145
+ self.day - 30
146146
)
147147

tests/date_tests/test_getters.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ def test_day_of_week(self):
2525
self.assertEqual(pendulum.MONDAY, d.day_of_week)
2626

2727
def test_day_of_year(self):
28-
d = Date(2012, 5, 7)
29-
self.assertEqual(128, d.day_of_year)
28+
d = Date(2015, 12, 31)
29+
self.assertEqual(365, d.day_of_year)
30+
d = Date(2016, 12, 31)
31+
self.assertEqual(366, d.day_of_year)
3032

3133
def test_days_in_month(self):
3234
d = Date(2012, 5, 7)

0 commit comments

Comments
 (0)