Add exact keyword when parsing and deprecate strict meaning

Author: sdispater

docs/_docs/instantiation.rst

@@ -274,15 +274,15 @@ When passing only time information the date will default to today.
 
 .. note::
 
-    You can pass the ``strict`` keyword argument to ``parse()`` to get the exact type
+    You can pass the ``exact`` keyword argument to ``parse()`` to get the exact type
     that the string represents:
 
     .. code-block:: python
 
         import pendulum
 
-        pendulum.parse('2012-05-03', strict=True)
+        pendulum.parse('2012-05-03', exact=True)
         # <Date [2012-05-03]>
 
-        pendulum.parse('12:04:23', strict=True)
+        pendulum.parse('12:04:23', exact=True)
         # <Time [12:04:23]>

pendulum/parser.py

@@ -30,7 +30,7 @@ def parse(self, text):
 
         parsed = super(Parser, self).parse(text)
 
-        if not self.is_strict():
+        if not self.is_exact():
             return self._create_pendulum_object(parsed)
 
         # Checking for date

pendulum/parsing/parser.py

@@ -2,6 +2,7 @@
 
 import re
 import copy
+import warnings
 
 from datetime import datetime, date, time
 from dateutil import parser
@@ -58,16 +59,35 @@ class Parser(object):
     DEFAULT_OPTIONS = {
         'day_first': False,
         'year_first': True,
-        'strict': False,
+        'exact': False,
         'now': None
     }
 
     def __init__(self, **options):
+        if 'strict' in options:
+            warnings.warn(
+                'The "strict" keyword when parsing will have '
+                'another meaning in version 2.0. Use "exact" instead.',
+                DeprecationWarning,
+                stacklevel=2
+            )
+
+            options['exact'] = options['strict']
+
         self._options = copy.copy(self.DEFAULT_OPTIONS)
         self._options.update(options)
 
     def is_strict(self):
-        return self._options['strict']
+        warnings.warn(
+            'is_strict() is deprecated. Use is_exact() instead.',
+            DeprecationWarning,
+            stacklevel=2
+        )
+
+        return self.is_exact()
+
+    def is_exact(self):
+        return self._options['exact']
 
     def now(self):
         return self._options['now'] or datetime.now()

tests/parsing_test/test_parser.py

@@ -472,49 +472,67 @@ def test_iso8601_ordinal_invalid(self):
 
         self.assertRaises(ParserError, Parser().parse, text)
 
-    def test_strict(self):
+    def test_exact(self):
         text = '2012'
 
-        parsed = Parser(strict=True).parse(text)
+        parsed = Parser(exact=True).parse(text)
         self.assertEqual(len(parsed), 3)
         self.assertEqual(2012, parsed['year'])
         self.assertEqual(1, parsed['month'])
         self.assertEqual(1, parsed['day'])
 
         text = '2012-03'
 
-        parsed = Parser(strict=True).parse(text)
+        parsed = Parser(exact=True).parse(text)
         self.assertEqual(len(parsed), 3)
         self.assertEqual(2012, parsed['year'])
         self.assertEqual(3, parsed['month'])
         self.assertEqual(1, parsed['day'])
 
         text = '2012-03-13'
 
-        parsed = Parser(strict=True).parse(text)
+        parsed = Parser(exact=True).parse(text)
         self.assertEqual(len(parsed), 3)
         self.assertEqual(2012, parsed['year'])
         self.assertEqual(3, parsed['month'])
         self.assertEqual(13, parsed['day'])
 
         text = '2012W055'
 
-        parsed = Parser(strict=True).parse(text)
+        parsed = Parser(exact=True).parse(text)
         self.assertEqual(len(parsed), 3)
         self.assertEqual(2012, parsed['year'])
         self.assertEqual(2, parsed['month'])
         self.assertEqual(3, parsed['day'])
 
         text = '2012007'
 
-        parsed = Parser(strict=True).parse(text)
+        parsed = Parser(exact=True).parse(text)
         self.assertEqual(len(parsed), 3)
         self.assertEqual(2012, parsed['year'])
         self.assertEqual(1, parsed['month'])
         self.assertEqual(7, parsed['day'])
 
         text = '20:12:05'
 
+        parsed = Parser(exact=True).parse(text)
+        self.assertEqual(len(parsed), 5)
+        self.assertEqual(20, parsed['hour'])
+        self.assertEqual(12, parsed['minute'])
+        self.assertEqual(5, parsed['second'])
+        self.assertEqual(0, parsed['subsecond'])
+
+    def test_strict_is_still_supported(self):
+        text = '2012'
+
+        parsed = Parser(strict=True).parse(text)
+        self.assertEqual(len(parsed), 3)
+        self.assertEqual(2012, parsed['year'])
+        self.assertEqual(1, parsed['month'])
+        self.assertEqual(1, parsed['day'])
+
+        text = '20:12:05'
+
         parsed = Parser(strict=True).parse(text)
         self.assertEqual(len(parsed), 5)
         self.assertEqual(20, parsed['hour'])