Add a create() method to the DateTime class to ease inheritance

Author: sdispater

pendulum/__init__.py

@@ -107,26 +107,17 @@ def datetime(
     """
     Creates a new DateTime instance from a specific date and time.
     """
-    if tz is not None:
-        tz = _safe_timezone(tz)
-
-    dt = _datetime.datetime(
-        year, month, day, hour, minute, second, microsecond, fold=fold
-    )
-
-    if tz is not None:
-        dt = tz.convert(dt, raise_on_unknown_times=raise_on_unknown_times)
-
-    return DateTime(
-        dt.year,
-        dt.month,
-        dt.day,
-        dt.hour,
-        dt.minute,
-        dt.second,
-        dt.microsecond,
-        tzinfo=dt.tzinfo,
-        fold=dt.fold,
+    return DateTime.create(
+        year,
+        month,
+        day,
+        hour=hour,
+        minute=minute,
+        second=second,
+        microsecond=microsecond,
+        tz=tz,
+        fold=fold,
+        raise_on_unknown_times=raise_on_unknown_times,
     )
 
 
@@ -211,35 +202,7 @@ def now(tz: Optional[Union[str, Timezone]] = None) -> DateTime:
     """
     Get a DateTime instance for the current date and time.
     """
-    if has_test_now():
-        test_instance = get_test_now()
-        _tz = _safe_timezone(tz)
-
-        if tz is not None and _tz != test_instance.timezone:
-            test_instance = test_instance.in_tz(_tz)
-
-        return test_instance
-
-    if tz is None or tz == "local":
-        dt = _datetime.datetime.now(local_timezone())
-    elif tz is UTC or tz == "UTC":
-        dt = _datetime.datetime.now(UTC)
-    else:
-        dt = _datetime.datetime.now(UTC)
-        tz = _safe_timezone(tz)
-        dt = dt.astimezone(tz)
-
-    return DateTime(
-        dt.year,
-        dt.month,
-        dt.day,
-        dt.hour,
-        dt.minute,
-        dt.second,
-        dt.microsecond,
-        tzinfo=dt.tzinfo,
-        fold=dt.fold,
-    )
+    return DateTime.now(tz)
 
 
 def today(tz: Union[str, Timezone] = "local") -> DateTime:

pendulum/datetime.py

@@ -30,9 +30,12 @@
 from .date import Date
 from .exceptions import PendulumException
 from .helpers import add_duration
+from .helpers import get_test_now
+from .helpers import has_test_now
 from .period import Period
 from .time import Time
 from .tz import UTC
+from .tz import local_timezone
 from .tz.timezone import FixedTimezone
 from .tz.timezone import Timezone
 from .utils._compat import PY38
@@ -72,12 +75,79 @@ class DateTime(datetime.datetime, Date):
         "century",
     ]
 
+    @classmethod
+    def create(
+        cls,
+        year: int,
+        month: int,
+        day: int,
+        hour: int = 0,
+        minute: int = 0,
+        second: int = 0,
+        microsecond: int = 0,
+        tz: Optional[Union[str, float, Timezone]] = UTC,
+        fold: Optional[int] = 1,
+        raise_on_unknown_times: bool = False,
+    ) -> "DateTime":
+        """
+        Creates a new DateTime instance from a specific date and time.
+        """
+        if tz is not None:
+            tz = pendulum._safe_timezone(tz)
+
+        dt = datetime.datetime(
+            year, month, day, hour, minute, second, microsecond, fold=fold
+        )
+
+        if tz is not None:
+            dt = tz.convert(dt, raise_on_unknown_times=raise_on_unknown_times)
+
+        return cls(
+            dt.year,
+            dt.month,
+            dt.day,
+            dt.hour,
+            dt.minute,
+            dt.second,
+            dt.microsecond,
+            tzinfo=dt.tzinfo,
+            fold=dt.fold,
+        )
+
     @classmethod
     def now(cls, tz: Optional[Union[str, Timezone]] = None) -> "DateTime":
         """
         Get a DateTime instance for the current date and time.
         """
-        return pendulum.now(tz)
+        if has_test_now():
+            test_instance = get_test_now()
+            _tz = pendulum._safe_timezone(tz)
+
+            if tz is not None and _tz != test_instance.timezone:
+                test_instance = test_instance.in_tz(_tz)
+
+            return test_instance
+
+        if tz is None or tz == "local":
+            dt = datetime.datetime.now(local_timezone())
+        elif tz is UTC or tz == "UTC":
+            dt = datetime.datetime.now(UTC)
+        else:
+            dt = datetime.datetime.now(UTC)
+            tz = pendulum._safe_timezone(tz)
+            dt = dt.astimezone(tz)
+
+        return cls(
+            dt.year,
+            dt.month,
+            dt.day,
+            dt.hour,
+            dt.minute,
+            dt.second,
+            dt.microsecond,
+            tzinfo=dt.tzinfo,
+            fold=dt.fold,
+        )
 
     @classmethod
     def utcnow(cls) -> "DateTime":
@@ -124,7 +194,7 @@ def set(
         if tz is None:
             tz = self.tz
 
-        return pendulum.datetime(
+        return DateTime.create(
             year, month, day, hour, minute, second, microsecond, tz=tz
         )
 
@@ -428,7 +498,7 @@ def is_long_year(self) -> bool:
         See link `https://en.wikipedia.org/wiki/ISO_8601#Week_dates`_
         """
         return (
-            pendulum.datetime(self.year, 12, 28, 0, 0, 0, tz=self.tz).isocalendar()[1]
+            DateTime.create(self.year, 12, 28, 0, 0, 0, tz=self.tz).isocalendar()[1]
             == 53
         )
 
@@ -502,7 +572,7 @@ def add(
         )
 
         if units_of_variable_length or self.tzinfo is None:
-            return pendulum.datetime(
+            return DateTime.create(
                 dt.year,
                 dt.month,
                 dt.day,
@@ -1225,7 +1295,7 @@ def replace(
         if fold is None:
             fold = self.fold
 
-        return pendulum.datetime(
+        return DateTime.create(
             year, month, day, hour, minute, second, microsecond, tz=tzinfo, fold=fold
         )