vcs: reduce pattern duplication

Author: abn

src/poetry/core/vcs/git.py

@@ -18,6 +18,16 @@
 NAME = r"[%\w~.\-]+"
 REV = r"[^@#]+?"
 SUBDIR = r"[\w\-/\\]+"
+PATTERN_SUFFIX = (
+    r"(?:"
+    rf"#(?:egg=.+?&subdirectory=|subdirectory=)(?P<subdirectory>{SUBDIR})"
+    r"|"
+    r"#egg=?.+"
+    r"|"
+    rf"[@#](?P<rev>{REV})(?:[&#](?:(?:egg=.+?&subdirectory=|subdirectory=)(?P<rev_subdirectory>{SUBDIR})|egg=.+?))?"
+    r")?"
+    r"$"
+)
 
 PATTERNS = [
     re.compile(
@@ -28,14 +38,7 @@
         rf"(:(?P<port>{PORT}))?"
         rf"(?P<pathname>[:/\\]({PATH}[/\\])?"
         rf"((?P<name>{NAME}?)(\.git|[/\\])?)?)"
-        r"(?:"
-        rf"#(?:egg=.+?&subdirectory=|subdirectory=)(?P<subdirectory>{SUBDIR})"
-        r"|"
-        r"#egg=?.+"
-        r"|"
-        rf"[@#](?P<rev>{REV})(?:[&#](?:(?:egg=.+?&subdirectory=|subdirectory=)(?P<rev_subdirectory>{SUBDIR})|egg=.+?))?"
-        r")?"
-        r"$"
+        rf"{PATTERN_SUFFIX}"
     ),
     re.compile(
         r"(git\+)?"
@@ -45,44 +48,23 @@
         rf"(:(?P<port>{PORT}))?"
         rf"(?P<pathname>({PATH})"
         rf"(?P<name>{NAME})(\.git|/)?)"
-        r"(?:"
-        rf"#(?:egg=.+?&subdirectory=|subdirectory=)(?P<subdirectory>{SUBDIR})"
-        r"|"
-        r"#egg=?.+"
-        r"|"
-        rf"[@#](?P<rev>{REV})(?:[&#](?:(?:egg=.+?&subdirectory=|subdirectory=)(?P<rev_subdirectory>{SUBDIR})|egg=.+?))?"
-        r")?"
-        r"$"
+        rf"{PATTERN_SUFFIX}"
     ),
     re.compile(
         rf"^(?:(?P<user>{USER})@)?"
         rf"(?P<resource>{RESOURCE})"
         rf"(:(?P<port>{PORT}))?"
         rf"(?P<pathname>([:/]{PATH}/)"
         rf"(?P<name>{NAME})(\.git|/)?)"
-        r"(?:"
-        rf"#(?:egg=.+?&subdirectory=|subdirectory=)(?P<subdirectory>{SUBDIR})"
-        r"|"
-        r"#egg=?.+"
-        r"|"
-        rf"[@#](?P<rev>{REV})(?:[&#](?:(?:egg=.+?&subdirectory=|subdirectory=)(?P<rev_subdirectory>{SUBDIR})|egg=.+?))?"
-        r")?"
-        r"$"
+        rf"{PATTERN_SUFFIX}"
     ),
     re.compile(
         rf"((?P<user>{USER})@)?"
         rf"(?P<resource>{RESOURCE})"
         r"[:/]{{1,2}}"
         rf"(?P<pathname>({PATH})"
         rf"(?P<name>{NAME})(\.git|/)?)"
-        r"(?:"
-        rf"#(?:egg=.+?&subdirectory=|subdirectory=)(?P<subdirectory>{SUBDIR})"
-        r"|"
-        r"#egg=?.+"
-        r"|"
-        rf"[@#](?P<rev>{REV})(?:[&#](?:(?:egg=.+?&subdirectory=|subdirectory=)(?P<rev_subdirectory>{SUBDIR})|egg=.+?))?"
-        r")?"
-        r"$"
+        rf"{PATTERN_SUFFIX}"
     ),
 ]