fix(venv_bundler): install all deps as not editable (#106)

Author: vladkolotvin

src/poetry_plugin_bundle/bundlers/venv_bundler.py

@@ -15,6 +15,7 @@
     from cleo.io.outputs.section_output import SectionOutput
     from poetry.core.constraints.version import Version
     from poetry.poetry import Poetry
+    from poetry.repositories.lockfile_repository import LockfileRepository
 
 
 class VenvBundler(Bundler):
@@ -57,6 +58,7 @@ def bundle(self, poetry: Poetry, io: IO) -> bool:
         from poetry.core.packages.package import Package
         from poetry.installation.installer import Installer
         from poetry.installation.operations.install import Install
+        from poetry.packages.locker import Locker
         from poetry.utils.env import EnvManager
         from poetry.utils.env import SystemEnv
         from poetry.utils.env import VirtualEnv
@@ -118,11 +120,20 @@ def bundle(self, poetry: Poetry, io: IO) -> bool:
 
         self._write(io, f"{message}: <info>Installing dependencies</info>")
 
+        class CustomLocker(Locker):
+            def locked_repository(self) -> LockfileRepository:
+                repo = super().locked_repository()
+                for package in repo.packages:
+                    package.develop = False
+                return repo
+
+        custom_locker = CustomLocker(poetry.locker.lock, poetry.local_config)
+
         installer = Installer(
             NullIO() if not io.is_debug() else io,
             env,
             poetry.package,
-            poetry.locker,
+            custom_locker,
             poetry.pool,
             poetry.config,
         )

tests/bundlers/test_venv_bundler.py

@@ -12,6 +12,7 @@
 from cleo.io.buffered_io import BufferedIO
 from poetry.core.packages.package import Package
 from poetry.factory import Factory
+from poetry.installation.operations.install import Install
 from poetry.puzzle.exceptions import SolverProblemError
 from poetry.repositories.repository import Repository
 from poetry.repositories.repository_pool import RepositoryPool
@@ -268,3 +269,43 @@ def test_bundler_can_filter_dependency_groups(
   • Bundled simple-project (1.2.3) into {path}
 """
     assert expected == io.fetch_output()
+
+
+def test_bundler_editable_deps(
+    io: BufferedIO, tmpdir: str, poetry: Poetry, mocker: MockerFixture, config: Config
+) -> None:
+    poetry = Factory().create_poetry(
+        Path(__file__).parent.parent / "fixtures" / "simple_project_with_editable_dep"
+    )
+    poetry.set_config(config)
+
+    install_spy = mocker.spy(Install, "__init__")
+    mocker.patch("poetry.installation.executor.Executor._execute_operation")
+
+    bundler = VenvBundler()
+    bundler.set_path(Path(tmpdir))
+
+    io.clear_output()
+
+    bundler.bundle(poetry, io)
+
+    path = tmpdir
+    python_version = ".".join(str(v) for v in sys.version_info[:3])
+    expected = f"""\
+  • Bundling simple-project (1.2.3) into {path}
+  • Bundling simple-project (1.2.3) into {path}: Removing existing virtual environment
+  • Bundling simple-project (1.2.3) into {path}: Creating a virtual environment using Python {python_version}
+  • Bundling simple-project (1.2.3) into {path}: Installing dependencies
+  • Bundling simple-project (1.2.3) into {path}: Installing simple-project (1.2.3)
+  • Bundled simple-project (1.2.3) into {path}
+"""
+    assert expected == io.fetch_output()
+
+    installed_packages = [call.args[1] for call in install_spy.call_args_list]
+    dep_installs = list(
+        filter(lambda package: package.name == "bar", installed_packages)
+    )
+    assert len(dep_installs) > 0
+
+    editable_installs = list(filter(lambda package: package.develop, dep_installs))
+    assert len(editable_installs) == 0

tests/fixtures/simple_project_with_editable_dep/README.rst

@@ -0,0 +1,2 @@
+My Package
+==========

tests/fixtures/simple_project_with_editable_dep/bar/bar/__init__.py

@@ -0,0 +1,25 @@
+[tool.poetry]
+name = "bar"
+version = "1.2.3"
+description = "Some description."
+authors = [
+    "Sébastien Eustace <[email protected]>"
+]
+license = "MIT"
+
+readme = "README.rst"
+
+homepage = "https://python-poetry.org"
+repository = "https://github.com/python-poetry/poetry"
+documentation = "https://python-poetry.org/docs"
+
+keywords = ["packaging", "dependency", "poetry"]
+
+classifiers = [
+    "Topic :: Software Development :: Build Tools",
+    "Topic :: Software Development :: Libraries :: Python Modules"
+]
+
+# Requirements
+[tool.poetry.dependencies]
+python = "~2.7 || ^3.4"

tests/fixtures/simple_project_with_editable_dep/bar/pyproject.toml

@@ -0,0 +1,30 @@
+[tool.poetry]
+name = "simple-project"
+version = "1.2.3"
+description = "Some description."
+authors = [
+    "Sébastien Eustace <[email protected]>"
+]
+license = "MIT"
+
+readme = "README.rst"
+
+homepage = "https://python-poetry.org"
+repository = "https://github.com/python-poetry/poetry"
+documentation = "https://python-poetry.org/docs"
+
+keywords = ["packaging", "dependency", "poetry"]
+
+classifiers = [
+    "Topic :: Software Development :: Build Tools",
+    "Topic :: Software Development :: Libraries :: Python Modules"
+]
+
+# Requirements
+[tool.poetry.dependencies]
+python = "~2.7 || ^3.4"
+bar = { path = "bar", develop = true }
+
+[tool.poetry.scripts]
+foo = "foo:bar"
+baz = "bar:baz.boom.bim"