pr feedback: remove redundant filtering and test fixture, improve solver test

Author: reesehyde

src/poetry/puzzle/provider.py

@@ -462,16 +462,7 @@ def incompatibilities_for(
             for dep in dependencies
             if dep.name not in self.UNSAFE_PACKAGES
             and self._python_constraint.allows_any(dep.python_constraint)
-            and (
-                not self._env
-                or dep.marker.validate(
-                    self._marker_values(
-                        self._active_root_extras
-                        if dependency_package.package.is_root()
-                        else dependency_package.dependency.extras
-                    )
-                )
-            )
+            and (not self._env or dep.marker.validate(self._env.marker_env))
         ]
         dependencies = self._get_dependencies_with_overrides(_dependencies, package)
 

tests/installation/fixtures/with-conflicting-dependencies-root-extras.test

@@ -4792,8 +4792,11 @@ def test_solver_resolves_duplicate_dependency_in_root_extra(
     repo.add_package(package_a1)
     repo.add_package(package_a2)
 
-    solver = Solver(package, pool, [], [], io, active_root_extras=extra)
-    transaction = solver.solve()
+    solver = Solver(
+        package, pool, [], [package_a1, package_a2], io, active_root_extras=extra
+    )
+    with solver.use_environment(MockEnv()):
+        transaction = solver.solve()
 
     check_solver_result(
         transaction,