prefer stdlib TemporaryDirectory

Author: dimbleby

src/poetry/inspection/info.py

@@ -7,6 +7,7 @@
 import tempfile
 
 from pathlib import Path
+from tempfile import TemporaryDirectory
 from typing import TYPE_CHECKING
 from typing import Any
 from typing import Mapping
@@ -21,7 +22,6 @@
 from poetry.core.packages.package import Package
 from poetry.core.pyproject.toml import PyProjectTOML
 from poetry.core.utils.helpers import parse_requires
-from poetry.core.utils.helpers import temporary_directory
 from poetry.core.version.markers import InvalidMarker
 from poetry.core.version.requirements import InvalidRequirement
 
@@ -316,7 +316,7 @@ def _from_sdist_file(cls, path: Path) -> PackageInfo:
         elif not zip:
             suffix = ".tar.gz"
 
-        with temporary_directory() as tmp_str:
+        with TemporaryDirectory(ignore_cleanup_errors=True) as tmp_str:
             tmp = Path(tmp_str)
             extractall(source=path, dest=tmp, zip=zip)
 

src/poetry/installation/chef.py

@@ -3,10 +3,10 @@
 import tempfile
 
 from pathlib import Path
+from tempfile import TemporaryDirectory
 from typing import TYPE_CHECKING
 
 from build import BuildBackendException
-from poetry.core.utils.helpers import temporary_directory
 
 from poetry.utils._compat import decode
 from poetry.utils.helpers import extractall
@@ -87,7 +87,7 @@ def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path
         suffix = archive.suffix
         zip = suffix == ".zip"
 
-        with temporary_directory() as tmp_dir:
+        with TemporaryDirectory(ignore_cleanup_errors=True) as tmp_dir:
             archive_dir = Path(tmp_dir)
             extractall(source=archive, dest=archive_dir, zip=zip)
 

src/poetry/repositories/http_repository.py

@@ -6,6 +6,7 @@
 from contextlib import contextmanager
 from contextlib import suppress
 from pathlib import Path
+from tempfile import TemporaryDirectory
 from typing import TYPE_CHECKING
 from typing import Any
 from typing import Iterator
@@ -16,7 +17,7 @@
 from packaging.metadata import parse_email
 from poetry.core.constraints.version import parse_constraint
 from poetry.core.packages.dependency import Dependency
-from poetry.core.utils.helpers import temporary_directory
+from poetry.core.packages.utils.link import Link
 from poetry.core.version.markers import parse_marker
 
 from poetry.config.config import Config
@@ -103,7 +104,7 @@ def _cached_or_downloaded_file(
         self, link: Link, *, raise_accepts_ranges: bool = False
     ) -> Iterator[Path]:
         self._log(f"Downloading: {link.url}", level="debug")
-        with temporary_directory() as temp_dir:
+        with TemporaryDirectory(ignore_cleanup_errors=True) as temp_dir:
             filepath = Path(temp_dir) / link.filename
             self._download(
                 link.url, filepath, raise_accepts_ranges=raise_accepts_ranges

src/poetry/utils/env/__init__.py

@@ -2,10 +2,9 @@
 
 from contextlib import contextmanager
 from pathlib import Path
+from tempfile import TemporaryDirectory
 from typing import TYPE_CHECKING
 
-from poetry.core.utils.helpers import temporary_directory
-
 from poetry.utils.env.base_env import Env
 from poetry.utils.env.env_manager import EnvManager
 from poetry.utils.env.exceptions import EnvCommandError
@@ -44,7 +43,7 @@ def ephemeral_environment(
     executable: Path | None = None,
     flags: dict[str, str | bool] | None = None,
 ) -> Iterator[VirtualEnv]:
-    with temporary_directory() as tmp_dir:
+    with TemporaryDirectory(ignore_cleanup_errors=True) as tmp_dir:
         # TODO: cache PEP 517 build environment corresponding to each project venv
         venv_dir = Path(tmp_dir) / ".venv"
         EnvManager.build_venv(

tests/packages/test_locker.py

@@ -1120,11 +1120,13 @@ def test_lock_file_resolves_file_url_symlinks(root: ProjectPackage) -> None:
 
     See https://github.com/python-poetry/poetry/issues/5849
     """
-    with tempfile.TemporaryDirectory() as d1:
+    with tempfile.TemporaryDirectory(ignore_cleanup_errors=True) as d1:
         symlink_path = Path(d1).joinpath("testsymlink")
-        with tempfile.TemporaryDirectory(dir=d1) as d2, tempfile.TemporaryDirectory(
-            dir=d1
-        ) as d4, tempfile.TemporaryDirectory(dir=d2) as d3, tempfile.NamedTemporaryFile(
+        with tempfile.TemporaryDirectory(
+            dir=d1, ignore_cleanup_errors=True
+        ) as d2, tempfile.TemporaryDirectory(dir=d1) as d4, tempfile.TemporaryDirectory(
+            dir=d2, ignore_cleanup_errors=True
+        ) as d3, tempfile.NamedTemporaryFile(
             dir=d4
         ) as source_file, tempfile.NamedTemporaryFile(dir=d3) as lock_file:
             lock_file.close()