fix clean option and add test

Author: radoering

docs/cli.md

@@ -746,7 +746,7 @@ poetry python install <PYTHON_VERSION>
 
 #### Options
 
-* `--clean`: Cleanup installation if check fails.
+* `--clean`: Clean up installation if check fails.
 * `--free-threaded`: Use free-threaded version if available.
 * `--implementation`: Python implementation to use. (cpython, pypy)
 * `--reinstall`: Reinstall if installation already exists.

src/poetry/console/commands/python/install.py

@@ -30,7 +30,7 @@ class PythonInstallCommand(Command):
     ]
 
     options: ClassVar[list[Option]] = [
-        option("clean", "c", "Cleanup installation if check fails.", flag=True),
+        option("clean", "c", "Clean up installation if check fails.", flag=True),
         option(
             "free-threaded", "t", "Use free-threaded version if available.", flag=True
         ),
@@ -117,7 +117,9 @@ def handle(self) -> int:
             self.io.write("<fg=red>Failed</>\n")
 
             if installer.installation_directory.exists() and self.option("clean"):
-                PythonRemoveCommand.remove_python_installation(request, impl, self.io)
+                PythonRemoveCommand.remove_python_installation(
+                    str(installer.version), impl, self.io
+                )
 
             raise e
 

tests/console/commands/python/test_python_install.py

@@ -4,6 +4,8 @@
 
 import pytest
 
+from poetry.core.constraints.version.version import Version
+
 from poetry.console.exceptions import PoetryRuntimeError
 from poetry.utils.env.python.installer import PythonDownloadNotFoundError
 from poetry.utils.env.python.installer import PythonInstallationError
@@ -15,6 +17,7 @@
     from cleo.testers.command_tester import CommandTester
     from pytest_mock import MockerFixture
 
+    from poetry.config.config import Config
     from tests.types import CommandTesterFactory
 
 
@@ -89,19 +92,32 @@ def test_install_failure(tester: CommandTester, mock_installer: MagicMock) -> No
     assert "foo\n" in tester.io.fetch_error()
 
 
-def test_install_corrupt(tester: CommandTester, mock_installer: MagicMock) -> None:
+@pytest.mark.parametrize("clean", [False, True])
+def test_install_corrupt(
+    tester: CommandTester, mock_installer: MagicMock, config: Config, clean: bool
+) -> None:
+    def create_install_dir() -> None:
+        (config.python_installation_dir / "cpython@3.11.9").mkdir(parents=True)
+
     mock_installer.return_value.exists.side_effect = [False, PoetryRuntimeError("foo")]
+    mock_installer.return_value.install.side_effect = create_install_dir
+    mock_installer.return_value.version = Version.parse("3.11.9")
 
     with pytest.raises(PoetryRuntimeError):
-        tester.execute("3.11")
+        clean_opt = "-c " if clean else ""
+        tester.execute(f"{clean_opt}3.11")
 
     mock_installer.assert_called_once_with("3.11", "cpython", False)
     mock_installer.return_value.install.assert_called_once()
 
-    assert tester.io.fetch_output() == (
+    expected = (
         "Downloading and installing 3.11 (cpython) ... Done\n"
         "Testing 3.11 (cpython) ... Failed\n"
     )
+    if clean:
+        expected += "Removing installation 3.11.9 (cpython) ... Done\n"
+
+    assert tester.io.fetch_output() == expected
 
 
 def test_install_success(tester: CommandTester, mock_installer: MagicMock) -> None: