Problems Parsing Commands in Bash Shell

[adam-grant-hendry]

First noticed in msys2/MINGW-packages Issue #13662, using poetry run in with the bash shell in GitHub Action CI exhibits strange behavior in specific cases with strings.

In commitizen PR #605, the following commands fail in GitHub Actions CI:
(NOTE: The commands are the same, but one is tested with single-quotes and the other with double-quotes.)

$ poetry run python -m pydocstyle --convention=google --add-ignore=D1,D415 --match-dir='^(?![.]|venv).*'

Link to Failing CI Run: https://github.com/commitizen-tools/commitizen/actions/runs/3292900770/jobs/5428806135
Expected Output: Runs and passes (no output)
Actual Output: 'venv).*' is not recognized as an internal or external command, operable program or batch file.

$ poetry run python -m pydocstyle --convention=google --add-ignore=D1,D415 --match-dir="^(?![.]|venv).*"

Link to Failing CI Run: https://github.com/commitizen-tools/commitizen/actions/runs/3293015007/jobs/5429057413
Expected Output: Runs and passes (no output)
Actual Output: 'venv).*' is not recognized as an internal or external command, operable program or batch file.

error_03.mp4

Any help would be greatly appreciated.

System Details

OS: determined with cmd.exe /c ver

Microsoft Windows [Version 10.0.19044.2006]

Git: determined with git --version

git version 2.38.1.windows.1

Bash: determined with uname:

kernel-name: MINGW64_NT-10.0-19044
kernel-release: 3.3.6-341.x86_64
kernel-version: 2022-09-05 20:28 UTC
machine: x86-64
operating-system: Msys

Initial Thoughts

If subprocess.Popen is a culprit, this opens a child process in Command Prompt since python looks at the Windows environment variable COMSPEC to determine which shell to run.

If poetry run is using subprocess.Popen, it could be opening a child Command Prompt shell, which doesn't always work well with single quotes. See:

• https://stackoverflow.com/questions/25534995/escape-double-quotes-in-git-config-from-cmd
• https://docs.python.org/3/library/subprocess.html#converting-an-argument-sequence-to-a-string-on-windows