Merge pull request #1 from python-poetry/linting

Add linting checks

Author: sdispater

.flake8

@@ -0,0 +1,16 @@
+[flake8]
+max-line-length = 88
+ignore = E501, E203, W503
+per-file-ignores = __init__.py:F401
+exclude =
+    .git
+    __pycache__
+    setup.py
+    build
+    dist
+    .venv
+    .tox
+    .mypy_cache
+    .pytest_cache
+    .vscode
+    .github

.github/workflows/tests.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [2.7, 3.5, 3.6, 3.7]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
 
     steps:
     - uses: actions/checkout@v1
@@ -47,7 +47,7 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: [2.7, 3.5, 3.6, 3.7]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
 
     steps:
     - uses: actions/checkout@v1
@@ -73,7 +73,7 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        python-version: [2.7, 3.5, 3.6, 3.7]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8]
 
     steps:
     - uses: actions/checkout@v1

.pre-commit-config.yaml

@@ -0,0 +1,24 @@
+repos:
+  - repo: https://github.com/psf/black
+    rev: stable
+    hooks:
+      - id: black
+
+  - repo: https://gitlab.com/pycqa/flake8
+    rev: 3.7.8
+    hooks:
+      - id: flake8
+
+  - repo: https://github.com/pre-commit/mirrors-isort
+    rev: v4.3.21
+    hooks:
+      - id: isort
+        additional_dependencies: [toml]
+        exclude: ^.*/?setup\.py$
+
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.3.0
+    hooks:
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: debug-statements

pyproject.toml

@@ -23,6 +23,7 @@ typing = { version = "^3.6", python = "~2.7 || ~3.4" }
 pytest = "^4.1"
 pytest-cov = "^2.8.1"
 tox = "^3.12"
+pre-commit = "^1.10"
 
 [tool.isort]
 line_length = 88

semver/patterns.py

@@ -1,5 +1,6 @@
 import re
 
+
 MODIFIERS = (
     "[._-]?"
     r"((?!post)(?:beta|b|c|pre|RC|alpha|a|patch|pl|p|dev)(?:(?:[.-]?\d+)*)?)?"

semver/version.py

@@ -2,6 +2,7 @@
 
 from typing import List
 from typing import Optional
+from typing import Union
 
 from .empty_constraint import EmptyConstraint
 from .exceptions import ParseVersionError

semver/version_constraint.py

@@ -1,11 +1,14 @@
+import semver
+
+
 class VersionConstraint:
     def is_empty(self):  # type: () -> bool
         raise NotImplementedError()
 
     def is_any(self):  # type: () -> bool
         raise NotImplementedError()
 
-    def allows(self, version):  # type: (Version) -> bool
+    def allows(self, version):  # type: (semver.Version) -> bool
         raise NotImplementedError()
 
     def allows_all(self, other):  # type: (VersionConstraint) -> bool

semver/version_range.py

@@ -1,3 +1,7 @@
+from typing import List
+
+import semver
+
 from .empty_constraint import EmptyConstraint
 from .version_constraint import VersionConstraint
 from .version_union import VersionUnion
@@ -58,7 +62,7 @@ def is_empty(self):
     def is_any(self):
         return self._min is None and self._max is None
 
-    def allows(self, other):  # type: (Version) -> bool
+    def allows(self, other):  # type: (semver.Version) -> bool
         if self._min is not None:
             if other < self._min:
                 return False

semver/version_union.py

@@ -1,3 +1,7 @@
+from typing import List
+
+import semver
+
 from .empty_constraint import EmptyConstraint
 from .version_constraint import VersionConstraint
 
@@ -72,7 +76,7 @@ def is_empty(self):
     def is_any(self):
         return False
 
-    def allows(self, version):  # type: (Version) -> bool
+    def allows(self, version):  # type: (semver.Version) -> bool
         return any([constraint.allows(version) for constraint in self._ranges])
 
     def allows_all(self, other):  # type: (VersionConstraint) -> bool
@@ -214,7 +218,7 @@ def our_next_range(include_current=True):
 
     def _ranges_for(
         self, constraint
-    ):  # type: (VersionConstraint) -> List[VersionRange]
+    ):  # type: (VersionConstraint) -> List[semver.VersionRange]
         from .version_range import VersionRange
 
         if constraint.is_empty():

tests/test_main.py

@@ -1,9 +1,9 @@
 import pytest
 
-from semver import parse_constraint
 from semver import Version
 from semver import VersionRange
 from semver import VersionUnion
+from semver import parse_constraint
 
 
 @pytest.mark.parametrize(