feat: raise exceptions on invalid 'create' and 'replace' commands

Author: azmeuk

scim2_cli/create.py

@@ -31,6 +31,9 @@ def create_payload(client, payload, indent):
 
 
 def create_factory(model):
+    if not model:
+        raise ClickException("Invalid model")
+
     exclude = unacceptable_fields(Context.RESOURCE_CREATION_REQUEST, model)
 
     @click.command(

scim2_cli/replace.py

@@ -31,6 +31,9 @@ def replace_payload(client, payload, indent):
 
 
 def replace_factory(model):
+    if not model:
+        raise ClickException("Invalid model")
+
     exclude = unacceptable_fields(Context.RESOURCE_REPLACEMENT_REQUEST, model)
     exclude.remove("id")
 

tests/test_create.py

@@ -3,6 +3,28 @@
 from scim2_cli import cli
 
 
+def test_no_command(runner, httpserver):
+    """Test that no command displays the help."""
+    result = runner.invoke(
+        cli,
+        ["--url", httpserver.url_for("/"), "create"],
+        catch_exceptions=False,
+    )
+    assert result.exit_code == 1, result.stdout
+    assert "create user --help" in result.stdout
+
+
+def test_invalid_command(runner, httpserver):
+    """Test invalid command."""
+    result = runner.invoke(
+        cli,
+        ["--url", httpserver.url_for("/"), "create", "invalid"],
+        catch_exceptions=False,
+    )
+    assert result.exit_code == 1, result.stdout
+    assert "Error: Invalid model" in result.stdout
+
+
 def test_no_command_stdin(runner, httpserver, simple_user_payload):
     """Test that JSON stdin is passed in the POST request."""
     response_payload = simple_user_payload("new-user")

tests/test_replace.py

@@ -3,6 +3,28 @@
 from scim2_cli import cli
 
 
+def test_no_command(runner, httpserver):
+    """Test that no command displays the help."""
+    result = runner.invoke(
+        cli,
+        ["--url", httpserver.url_for("/"), "replace"],
+        catch_exceptions=False,
+    )
+    assert result.exit_code == 1, result.stdout
+    assert "replace user --help" in result.stdout
+
+
+def test_invalid_command(runner, httpserver):
+    """Test invalid command."""
+    result = runner.invoke(
+        cli,
+        ["--url", httpserver.url_for("/"), "replace", "invalid"],
+        catch_exceptions=False,
+    )
+    assert result.exit_code == 1, result.stdout
+    assert "Error: Invalid model" in result.stdout
+
+
 def test_no_command_stdin(runner, httpserver, simple_user_payload):
     """Test that JSON stdin is passed in the PUT request."""
     response_payload = simple_user_payload("old-user")