fix: don't execute PATCH tests when the ServiceProviderConfig advises patch is not supported

Author: azmeuk

doc/changelog.rst

@@ -7,6 +7,7 @@ Changelog
 Fixed
 ^^^^^
 - Discovery checkers are always executed, even with tag filtering.
+- Don't execute PATCH tests when the ServiceProviderConfig advises patch is not supported.
 
 [0.2.1] - 2025-08-13
 --------------------

scim2_tester/checkers/patch_add.py

@@ -38,13 +38,25 @@ def check_add_attribute(
     **Status:**
     - :attr:`~scim2_tester.Status.SUCCESS`: Attribute successfully added
     - :attr:`~scim2_tester.Status.ERROR`: Failed to add attribute
-    - :attr:`~scim2_tester.Status.SKIPPED`: No addable attributes found
+    - :attr:`~scim2_tester.Status.SKIPPED`: No addable attributes found or PATCH not supported
 
     .. pull-quote:: :rfc:`RFC 7644 Section 3.5.2.1 - Add Operation <7644#section-3.5.2.1>`
 
        "The 'add' operation is used to add a new attribute and/or values to
        an existing resource."
     """
+    if (
+        context.client.service_provider_config
+        and not context.client.service_provider_config.patch.supported
+    ):
+        return [
+            CheckResult(
+                status=Status.SKIPPED,
+                reason="PATCH operations not supported by server",
+                resource_type=model.__name__,
+            )
+        ]
+
     results = []
     all_urns = list(
         iter_all_urns(

scim2_tester/checkers/patch_remove.py

@@ -36,14 +36,26 @@ def check_remove_attribute(
     **Status:**
     - :attr:`~scim2_tester.Status.SUCCESS`: Attribute successfully removed
     - :attr:`~scim2_tester.Status.ERROR`: Failed to remove attribute or attribute still exists
-    - :attr:`~scim2_tester.Status.SKIPPED`: No removable attributes found
+    - :attr:`~scim2_tester.Status.SKIPPED`: No removable attributes found or PATCH not supported
 
     .. pull-quote:: :rfc:`RFC 7644 Section 3.5.2.2 - Remove Operation <7644#section-3.5.2.2>`
 
        "The 'remove' operation removes the value at the target location specified
        by the required attribute 'path'. The operation performs the following
        functions, depending on the target location specified by 'path'."
     """
+    if (
+        context.client.service_provider_config
+        and not context.client.service_provider_config.patch.supported
+    ):
+        return [
+            CheckResult(
+                status=Status.SKIPPED,
+                reason="PATCH operations not supported by server",
+                resource_type=model.__name__,
+            )
+        ]
+
     results = []
     all_urns = list(
         iter_all_urns(

scim2_tester/checkers/patch_replace.py

@@ -37,13 +37,25 @@ def check_replace_attribute(
     **Status:**
     - :attr:`~scim2_tester.Status.SUCCESS`: Attribute successfully replaced
     - :attr:`~scim2_tester.Status.ERROR`: Failed to replace attribute
-    - :attr:`~scim2_tester.Status.SKIPPED`: No replaceable attributes found
+    - :attr:`~scim2_tester.Status.SKIPPED`: No replaceable attributes found or PATCH not supported
 
     .. pull-quote:: :rfc:`RFC 7644 Section 3.5.2.3 - Replace Operation <7644#section-3.5.2.3>`
 
        "The 'replace' operation replaces the value at the target location
        specified by the 'path'."
     """
+    if (
+        context.client.service_provider_config
+        and not context.client.service_provider_config.patch.supported
+    ):
+        return [
+            CheckResult(
+                status=Status.SKIPPED,
+                reason="PATCH operations not supported by server",
+                resource_type=model.__name__,
+            )
+        ]
+
     results = []
     all_urns = list(
         iter_all_urns(

tests/test_patch_add.py

@@ -408,3 +408,20 @@ def test_patch_add_query_failure_after_patch(httpserver, testing_context):
         and "was not added or has incorrect value" in r.reason
     ]
     assert len(error_results) > 0
+
+
+def test_patch_not_supported(testing_context):
+    """Test PATCH add returns SKIPPED when PATCH is not supported."""
+    from unittest.mock import Mock
+
+    # Mock ServiceProviderConfig with patch.supported = False
+    mock_service_provider_config = Mock()
+    mock_service_provider_config.patch.supported = False
+    testing_context.client.service_provider_config = mock_service_provider_config
+
+    results = check_add_attribute(testing_context, User)
+
+    assert len(results) == 1
+    assert results[0].status == Status.SKIPPED
+    assert "PATCH operations not supported by server" in results[0].reason
+    assert results[0].resource_type == "User"

tests/test_patch_remove.py

@@ -437,3 +437,20 @@ def test_patch_remove_writeonly_attribute(testing_context):
         if r.status == Status.SUCCESS and "password" in r.data.get("urn", "")
     ]
     assert len(success_results) > 0
+
+
+def test_patch_not_supported(testing_context):
+    """Test PATCH remove returns SKIPPED when PATCH is not supported."""
+    from unittest.mock import Mock
+
+    # Mock ServiceProviderConfig with patch.supported = False
+    mock_service_provider_config = Mock()
+    mock_service_provider_config.patch.supported = False
+    testing_context.client.service_provider_config = mock_service_provider_config
+
+    results = check_remove_attribute(testing_context, User)
+
+    assert len(results) == 1
+    assert results[0].status == Status.SKIPPED
+    assert "PATCH operations not supported by server" in results[0].reason
+    assert results[0].resource_type == "User"

tests/test_patch_replace.py

@@ -306,3 +306,20 @@ def test_patch_replace_attribute_not_replaced(httpserver, testing_context):
         if r.status == Status.ERROR and "was not replaced" in r.reason
     ]
     assert len(error_results) > 0
+
+
+def test_patch_not_supported(testing_context):
+    """Test PATCH replace returns SKIPPED when PATCH is not supported."""
+    from unittest.mock import Mock
+
+    # Mock ServiceProviderConfig with patch.supported = False
+    mock_service_provider_config = Mock()
+    mock_service_provider_config.patch.supported = False
+    testing_context.client.service_provider_config = mock_service_provider_config
+
+    results = check_replace_attribute(testing_context, User)
+
+    assert len(results) == 1
+    assert results[0].status == Status.SKIPPED
+    assert "PATCH operations not supported by server" in results[0].reason
+    assert results[0].resource_type == "User"