fix: correctly set values for Reference objects in parent object (#37)

`value` and `ref` values in `MultiValuedComplexAttribute` are coherent (the id in `value` is extracted from `ref`)

Co-authored-by: Éloi Rivard <eloi@yaal.coop>

Author: J-Bu

doc/changelog.rst

@@ -7,6 +7,7 @@ Changelog
 Fixed
 ^^^^^
 - Sort results in get_all_available_tags, so it can be used with pytest-xdist.
+- `generate_random_value` generate coherent `ref` and `value` values for complex attributes. :pr:`30` :pr:`37`
 
 [0.2.0] - 2025-08-12
 --------------------

scim2_tester/filling.py

@@ -11,6 +11,7 @@
 from scim2_models import ComplexAttribute
 from scim2_models import Extension
 from scim2_models import ExternalReference
+from scim2_models import MultiValuedComplexAttribute
 from scim2_models import Mutability
 from scim2_models import Reference
 from scim2_models import Resource
@@ -123,6 +124,9 @@ def generate_random_value(
     elif isclass(field_type) and issubclass(field_type, Enum):
         value = random.choice(list(field_type))
 
+    elif isclass(field_type) and issubclass(field_type, MultiValuedComplexAttribute):
+        value = fill_mvca_with_random_values(context, field_type())  # type: ignore[arg-type]
+
     elif isclass(field_type) and issubclass(field_type, ComplexAttribute):
         value = fill_with_random_values(context, field_type())  # type: ignore[arg-type]
 
@@ -172,3 +176,24 @@ def fill_with_random_values(
         set_value_by_urn(obj, urn, value)
 
     return obj
+
+
+def fill_mvca_with_random_values(
+    context: "CheckContext",
+    obj: MultiValuedComplexAttribute,
+) -> Resource[Any] | None:
+    """Fill a MultiValuedComplexAttribute with random values.
+
+    For SCIM reference fields, correctly sets the value field to match
+    the ID extracted from the reference URL.
+    """
+    fill_with_random_values(context, obj)
+    ref_type = type(obj).get_field_root_type("ref")
+    if (
+        get_origin(ref_type) is Reference
+        and get_args(ref_type)
+        and get_args(ref_type)[0] not in (URIReference, ExternalReference, Any)
+        and (ref := getattr(obj, "ref", None))
+    ):
+        obj.value = ref.rsplit("/", 1)[-1]
+    return obj

tests/test_filling.py

@@ -33,6 +33,30 @@ def test_model_resolution_from_reference_type(testing_context):
     assert result != Group
 
 
+def test_generate_random_value_for_reference(testing_context, httpserver):
+    """Validates random value generation for reference fields."""
+    group = Group()
+
+    # Mock HTTP response for user creation
+    user_data = {
+        "schemas": ["urn:ietf:params:scim:schemas:core:2.0:User"],
+        "id": "test-user-id",
+        "userName": "test-user",
+        "meta": {
+            "resourceType": "User",
+            "location": f"http://localhost:{httpserver.port}/Users/test-user-id",
+        },
+    }
+    httpserver.expect_request("/Users", method="POST").respond_with_json(
+        user_data, status=201
+    )
+
+    result = fill_with_random_values(testing_context, group)
+
+    assert len(result.members) == 1
+    assert result.members[0].value == result.members[0].ref.rsplit("/", 1)[-1]
+
+
 def test_fill_with_empty_field_list(testing_context):
     """Confirms no fields are modified when empty field list provided."""
     user = User(user_name="test")