Remove connection_profile as it is replaced with get_profile

`connection_profile` was added early in to the development of
settings dataclasses. However, it was incorrectly added to the
object class rather than interface.

`get_profile` is equivalent and can fetch secrets. No reason
to keep duplicated functionality in before it is released to
stable version.

Author: igo95862

examples/async/list-connections-async.py

@@ -36,7 +36,7 @@ async def list_connection_profiles_async() -> None:
 
 async def print_connection_profile(connection_path: str) -> None:
     connectionsettings_service = NetworkConnectionSettings(connection_path)
-    profile = await connectionsettings_service.connection_profile()
+    profile = await connectionsettings_service.get_profile()
     connection = profile.connection
     print("-------------------------------------------------------------")
     print("name:", connection.connection_id)

examples/async/netdevinfo-async.py

@@ -43,7 +43,7 @@ async def get_most_recent_connection_id(ifname: str, dev_type: str) -> Optional[
     conns = {}
     for connection_path in connection_paths:
         connection_manager = NetworkConnectionSettings(connection_path)
-        connection = (await connection_manager.connection_profile()).connection
+        connection = (await connection_manager.get_profile()).connection
         # Filter connection profiles matching the connection type for the device:
         if connection.connection_type != getattr(ConnectionType, dev_type):
             continue

examples/async/update-connection-async.py

@@ -3,7 +3,7 @@
 #
 # Update a property of a connection profile, looked up by connection id
 #
-# This version uses connection_manager.connection_profile().to_settings_dict()
+# This version uses connection_manager.get_profile().to_settings_dict()
 # to retrieve the connection profile from NetworkManager as a settings dict.
 #
 # It then updates it dynamically using the given arguments:
@@ -34,9 +34,9 @@ async def update_connection_async(args: Dict[str, Any]) -> None:
         print(f"No connection {id}, create with add-wifi-psk-connection-async")
         return
 
-    # Get the profile settings of the first connecttion with given id
+    # Get the profile settings of the first connection with given id
     connection_manager = NetworkConnectionSettings(connection_paths[0])
-    existing_connection_profile = await connection_manager.connection_profile()
+    existing_connection_profile = await connection_manager.get_profile()
     settings = existing_connection_profile.to_settings_dict()
 
     # Update the given setting's property using the given value

examples/block/list-connections.py

@@ -31,8 +31,8 @@ def list_connection_profiles_blocking() -> None:
 
 
 def print_connection_profile_blocking(connection_path: str) -> None:
-    """Show the use of NetworkConnectionSettings(path).connection_profile()"""
-    profile = NetworkConnectionSettings(connection_path).connection_profile()
+    """Show the use of NetworkConnectionSettings(path).get_profile()"""
+    profile = NetworkConnectionSettings(connection_path).get_profile()
     print("-------------------------------------------------------------")
     print("name:", profile.connection.connection_id)
     print("uuid:", profile.connection.uuid)

examples/block/netdevinfo.py

@@ -42,7 +42,7 @@ def get_most_recent_connection_id(ifname: str, dev_type: str) -> Optional[str]:
     conns = {}
     for connection_path in connection_paths:
         connection_manager = NetworkConnectionSettings(connection_path)
-        connection = connection_manager.connection_profile().connection
+        connection = connection_manager.get_profile().connection
         # Filter connection profiles matching the connection type for the device:
         if connection.connection_type != getattr(ConnectionType, dev_type):
             continue

sdbus_async/networkmanager/objects.py

@@ -67,7 +67,6 @@
     NetworkManagerVPNConnectionInterfaceAsync,
     NetworkManagerWifiP2PPeerInterfaceAsync,
 )
-from .settings.profile import ConnectionProfile
 from .types import NetworkManagerConnectionProperties
 
 NETWORK_MANAGER_SERVICE_NAME = 'org.freedesktop.NetworkManager'
@@ -224,13 +223,6 @@ def __init__(self, settings_path: str,
             settings_path,
             bus)
 
-    async def connection_profile(self) -> ConnectionProfile:
-        """Return a ConnectionProfile object containing all profile settings
-
-        :return: Nested dataclass containing all settings of the profile
-        """
-        return ConnectionProfile.from_dbus(await self.get_settings())
-
 
 class NetworkDeviceGeneric(
         NetworkManagerDeviceInterfaceAsync,

sdbus_block/networkmanager/objects.py

@@ -67,7 +67,6 @@
     NetworkManagerVPNConnectionInterface,
     NetworkManagerWifiP2PPeerInterface,
 )
-from .settings.profile import ConnectionProfile
 from .types import NetworkManagerConnectionProperties
 
 NETWORK_MANAGER_SERVICE_NAME = 'org.freedesktop.NetworkManager'
@@ -213,13 +212,6 @@ def __init__(self, settings_path: str,
             settings_path,
             bus)
 
-    def connection_profile(self) -> ConnectionProfile:
-        """Return a ConnectionProfile object containing all profile settings
-
-        :return: Nested dataclass containing all settings of the profile
-        """
-        return ConnectionProfile.from_dbus(self.get_settings())
-
 
 class NetworkDeviceGeneric(
         NetworkManagerDeviceInterface,