chore(deps): update ruff to 0.9.0

nijel · nijel · commit 6e19edfdf566 · 2025-01-10T09:02:18.000+01:00
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -10,7 +10,7 @@ repos:
   - id: mixed-line-ending
     args: [--fix=lf]
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.8.6
+  rev: v0.9.0
   hooks:
   - id: ruff
     args: [--fix, --exit-non-zero-on-fix]
diff --git a/social_core/backends/email.py b/social_core/backends/email.py
@@ -1,3 +1,4 @@
+# noqa: A005
 """
 Legacy Email backend, docs at:
     https://python-social-auth.readthedocs.io/en/latest/backends/email.html
diff --git a/social_core/backends/facebook.py b/social_core/backends/facebook.py
@@ -146,7 +146,7 @@ def do_auth(self, access_token, response=None, *args, **kwargs):
             # account on further logins), this app cannot allow it to
             # continue with the auth process.
             raise AuthUnknownError(
-                self, "An error occurred while retrieving " "users Facebook data"
+                self, "An error occurred while retrieving users Facebook data"
             )
 
         data["access_token"] = access_token
diff --git a/social_core/backends/saml.py b/social_core/backends/saml.py
@@ -34,9 +34,9 @@ def __init__(self, name, **kwargs):
         self.name = name
         # name should be a slug and must not contain a colon, which
         # could conflict with uid prefixing:
-        assert (
-            ":" not in self.name and " " not in self.name
-        ), 'IdP "name" should be a slug (short, no spaces)'
+        assert ":" not in self.name and " " not in self.name, (
+            'IdP "name" should be a slug (short, no spaces)'
+        )
         self.conf = kwargs
 
     def get_user_permanent_id(self, attributes):
diff --git a/social_core/backends/vk.py b/social_core/backends/vk.py
@@ -151,7 +151,7 @@ def auth_complete(self, *args, **kwargs):
                 "_".join([key, self.data.get("viewer_id"), secret]).encode("utf-8")
             ).hexdigest()
             if check_key != auth_key:
-                raise ValueError("VK.com authentication failed: invalid " "auth key")
+                raise ValueError("VK.com authentication failed: invalid auth key")
 
         user_check = self.setting("USERMODE")
         user_id = self.data.get("viewer_id")
diff --git a/social_core/strategy.py b/social_core/strategy.py
@@ -29,9 +29,7 @@ def render_string(self, html, context):
 
 
 class BaseStrategy:
-    ALLOWED_CHARS = (
-        "abcdefghijklmnopqrstuvwxyz" "ABCDEFGHIJKLMNOPQRSTUVWXYZ" "0123456789"
-    )
+    ALLOWED_CHARS = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
     DEFAULT_TEMPLATE_STRATEGY = BaseTemplateStrategy
 
     def __init__(self, storage=None, tpl=None):
diff --git a/social_core/tests/backends/oauth.py b/social_core/tests/backends/oauth.py
@@ -88,7 +88,7 @@ def do_start(self):
 
 class OAuth1Test(BaseOAuthTest):
     request_token_body = None
-    raw_complete_url = "/complete/{0}/?oauth_verifier=bazqux&" "oauth_token=foobar"
+    raw_complete_url = "/complete/{0}/?oauth_verifier=bazqux&oauth_token=foobar"
 
     def request_token_handler(self):
         HTTPretty.register_uri(
diff --git a/social_core/tests/backends/test_behance.py b/social_core/tests/backends/test_behance.py
@@ -22,18 +22,15 @@ class BehanceOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
                 "state": "",
                 "fields": ["Programming", "Web Design", "Web Development"],
                 "images": {
-                    "32": "https://www.behance.net/assets/img/profile/"
-                    "no-image-32.jpg",
-                    "50": "https://www.behance.net/assets/img/profile/"
-                    "no-image-50.jpg",
+                    "32": "https://www.behance.net/assets/img/profile/no-image-32.jpg",
+                    "50": "https://www.behance.net/assets/img/profile/no-image-50.jpg",
                     "115": "https://www.behance.net/assets/img/profile/"
                     "no-image-138.jpg",
                     "129": "https://www.behance.net/assets/img/profile/"
                     "no-image-138.jpg",
                     "138": "https://www.behance.net/assets/img/profile/"
                     "no-image-138.jpg",
-                    "78": "https://www.behance.net/assets/img/profile/"
-                    "no-image-78.jpg",
+                    "78": "https://www.behance.net/assets/img/profile/no-image-78.jpg",
                 },
                 "id": 1010101,
                 "occupation": "Software Developer",
diff --git a/social_core/tests/backends/test_disqus.py b/social_core/tests/backends/test_disqus.py
@@ -28,8 +28,7 @@ class DisqusOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
                 "reputation": 1.231755,
                 "avatar": {
                     "small": {
-                        "permalink": "https://disqus.com/api/users/avatars/"
-                        "foobar.jpg",
+                        "permalink": "https://disqus.com/api/users/avatars/foobar.jpg",
                         "cache": "https://securecdn.disqus.com/uploads/"
                         "users/453/4556/avatar32.jpg?1285535379",
                     },
@@ -38,8 +37,7 @@ class DisqusOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
                     "cache": "https://securecdn.disqus.com/uploads/users/453/"
                     "4556/avatar92.jpg?1285535379",
                     "large": {
-                        "permalink": "https://disqus.com/api/users/avatars/"
-                        "foobar.jpg",
+                        "permalink": "https://disqus.com/api/users/avatars/foobar.jpg",
                         "cache": "https://securecdn.disqus.com/uploads/users/"
                         "453/4556/avatar92.jpg?1285535379",
                     },
diff --git a/social_core/tests/backends/test_foursquare.py b/social_core/tests/backends/test_foursquare.py
@@ -19,8 +19,7 @@ class FoursquareOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
             },
             "response": {
                 "user": {
-                    "photo": "https://is0.4sqi.net/userpix_thumbs/"
-                    "BYKIT01VN4T4BISN.jpg",
+                    "photo": "https://is0.4sqi.net/userpix_thumbs/BYKIT01VN4T4BISN.jpg",
                     "pings": False,
                     "homeCity": "Foo, Bar",
                     "id": "1010101",
diff --git a/social_core/tests/backends/test_mapmyfitness.py b/social_core/tests/backends/test_mapmyfitness.py
@@ -36,12 +36,12 @@ class MapMyFitnessOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
             "_links": {
                 "stats": [
                     {
-                        "href": "/v7.0/user_stats/112233/?" "aggregate_by_period=month",
+                        "href": "/v7.0/user_stats/112233/?aggregate_by_period=month",
                         "id": "112233",
                         "name": "month",
                     },
                     {
-                        "href": "/v7.0/user_stats/112233/?" "aggregate_by_period=year",
+                        "href": "/v7.0/user_stats/112233/?aggregate_by_period=year",
                         "id": "112233",
                         "name": "year",
                     },
@@ -51,13 +51,12 @@ class MapMyFitnessOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
                         "name": "day",
                     },
                     {
-                        "href": "/v7.0/user_stats/112233/?" "aggregate_by_period=week",
+                        "href": "/v7.0/user_stats/112233/?aggregate_by_period=week",
                         "id": "112233",
                         "name": "week",
                     },
                     {
-                        "href": "/v7.0/user_stats/112233/?"
-                        "aggregate_by_period=lifetime",
+                        "href": "/v7.0/user_stats/112233/?aggregate_by_period=lifetime",
                         "id": "112233",
                         "name": "lifetime",
                     },
@@ -88,7 +87,7 @@ class MapMyFitnessOAuth2Test(OAuth2Test, BaseAuthUrlTestMixin):
                 ],
                 "documentation": [{"href": "https://www.mapmyapi.com/docs/User"}],
                 "workouts": [
-                    {"href": "/v7.0/workout/?user=112233&" "order_by=-start_datetime"}
+                    {"href": "/v7.0/workout/?user=112233&order_by=-start_datetime"}
                 ],
                 "deactivation": [{"href": "/v7.0/user_deactivation/"}],
                 "self": [{"href": "/v7.0/user/112233/", "id": "112233"}],
diff --git a/social_core/tests/backends/test_ngpvan.py b/social_core/tests/backends/test_ngpvan.py
@@ -62,9 +62,9 @@ class NGPVANActionIDOpenIDTest(OpenIdTest):
             "openid.alias3.type.alias2": "http://openid.net/schema/contact/interne"
             "t/email",
             "openid.alias3.value.alias2": "testuser@user.local",
-            "openid.alias3.type.alias3": "http://openid.net/schema/namePerson/firs" "t",
+            "openid.alias3.type.alias3": "http://openid.net/schema/namePerson/first",
             "openid.alias3.value.alias3": "John",
-            "openid.alias3.type.alias4": "http://openid.net/schema/namePerson/las" "t",
+            "openid.alias3.type.alias4": "http://openid.net/schema/namePerson/last",
             "openid.alias3.value.alias4": "Smith",
             "openid.alias3.type.alias5": "http://axschema.org/namePerson/first",
             "openid.alias3.value.alias5": "John",
diff --git a/social_core/tests/backends/test_twitter.py b/social_core/tests/backends/test_twitter.py
@@ -6,7 +6,7 @@
 
 class TwitterOAuth1Test(OAuth1Test, OAuth1AuthUrlTestMixin):
     backend_path = "social_core.backends.twitter.TwitterOAuth"
-    user_data_url = "https://api.twitter.com/1.1/account/" "verify_credentials.json"
+    user_data_url = "https://api.twitter.com/1.1/account/verify_credentials.json"
     expected_username = "foobar"
     access_token_body = json.dumps({"access_token": "foobar", "token_type": "bearer"})
     request_token_body = urlencode(
@@ -128,8 +128,7 @@ def test_partial_pipeline(self):
 class TwitterOAuth1IncludeEmailTest(OAuth1Test, OAuth1AuthUrlTestMixin):
     backend_path = "social_core.backends.twitter.TwitterOAuth"
     user_data_url = (
-        "https://api.twitter.com/1.1/account/"
-        "verify_credentials.json?include_email=true"
+        "https://api.twitter.com/1.1/account/verify_credentials.json?include_email=true"
     )
     expected_username = "foobar"
     access_token_body = json.dumps({"access_token": "foobar", "token_type": "bearer"})
diff --git a/social_core/tests/backends/test_yahoo.py b/social_core/tests/backends/test_yahoo.py
@@ -9,7 +9,7 @@
 
 class YahooOAuth1Test(OAuth1Test, OAuth1AuthUrlTestMixin):
     backend_path = "social_core.backends.yahoo.YahooOAuth"
-    user_data_url = "https://social.yahooapis.com/v1/user/a-guid/profile?" "format=json"
+    user_data_url = "https://social.yahooapis.com/v1/user/a-guid/profile?format=json"
     expected_username = "foobar"
     access_token_body = json.dumps({"access_token": "foobar", "token_type": "bearer"})
     request_token_body = urlencode(
diff --git a/social_core/tests/test_exceptions.py b/social_core/tests/test_exceptions.py
@@ -86,7 +86,7 @@ class AuthCanceledWithExtraMessageTest(BaseExceptionTestCase):
 
 class AuthUnknownErrorTest(BaseExceptionTestCase):
     exception = AuthUnknownError("foobar", "some error")
-    expected_message = "An unknown error happened while " "authenticating some error"
+    expected_message = "An unknown error happened while authenticating some error"
 
 
 class AuthStateForbiddenTest(BaseExceptionTestCase):

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+# noqa: A005`
`1`	`2`	`"""`
`2`	`3`	`Legacy Email backend, docs at:`
`3`	`4`	`https://python-social-auth.readthedocs.io/en/latest/backends/email.html`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ def do_auth(self, access_token, response=None, args, *kwargs):`
`146`	`146`	`# account on further logins), this app cannot allow it to`
`147`	`147`	`# continue with the auth process.`
`148`	`148`	`raise AuthUnknownError(`
`149`		`- self, "An error occurred while retrieving " "users Facebook data"`
	`149`	`+ self, "An error occurred while retrieving users Facebook data"`
`150`	`150`	`)`
`151`	`151`
`152`	`152`	`data["access_token"] = access_token`