chore: use next() instead of getting first element from list

Author: nijel

social_core/backends/apple.py

@@ -106,7 +106,7 @@ def get_apple_jwk(self, kid=None):
             raise AuthFailed(self, "Invalid jwk response")
 
         if kid:
-            return json.dumps([key for key in keys if key["kid"] == kid][0])
+            return json.dumps(next(key for key in keys if key["kid"] == kid))
         return (json.dumps(key) for key in keys)
 
     def decode_id_token(self, id_token):

social_core/backends/clever.py

@@ -21,7 +21,7 @@ def get_user_id(self, details, response):
         return response.get("data", {}).get("id")
 
     def get_user_type(self, data):
-        return list(data.get("data", {}).get("roles", {}).keys())[0]
+        return next(iter(data.get("data", {}).get("roles", {}).keys()))
 
     def get_user_details(self, response):
         """Return user details from Classlink account"""

social_core/tests/backends/oauth.py

@@ -118,7 +118,7 @@ def do_refresh_token(self):
             status=200,
             body=self.refresh_token_body,
         )
-        user = list(User.cache.values())[0]
+        user = next(iter(User.cache.values()))
         social = user.social[0]
         social.refresh_token(strategy=self.strategy, **self.refresh_token_arguments())
         return user, social
@@ -136,17 +136,17 @@ def do_login(self):
         user = super().do_login()
 
         requests = latest_requests()
-        auth_request = [
+        auth_request = next(
             r for r in requests if self.backend.authorization_url() in r.url
-        ][0]
+        )
         code_challenge = auth_request.querystring.get("code_challenge")[0]
         code_challenge_method = auth_request.querystring.get("code_challenge_method")[0]
         self.assertIsNotNone(code_challenge)
         self.assertEqual(code_challenge_method, "plain")
 
-        auth_complete = [
+        auth_complete = next(
             r for r in requests if self.backend.access_token_url() in r.url
-        ][0]
+        )
         code_verifier = auth_complete.parsed_body.get("code_verifier")[0]
         self.assertEqual(code_challenge, code_verifier)
 
@@ -159,17 +159,17 @@ def do_login(self):
         user = super().do_login()
 
         requests = latest_requests()
-        auth_request = [
+        auth_request = next(
             r for r in requests if self.backend.authorization_url() in r.url
-        ][0]
+        )
         code_challenge = auth_request.querystring.get("code_challenge")[0]
         code_challenge_method = auth_request.querystring.get("code_challenge_method")[0]
         self.assertIsNotNone(code_challenge)
         self.assertTrue(code_challenge_method in ["s256", "S256"])
 
-        auth_complete = [
+        auth_complete = next(
             r for r in requests if self.backend.access_token_url() in r.url
-        ][0]
+        )
         code_verifier = auth_complete.parsed_body.get("code_verifier")[0]
         self.assertEqual(
             self.backend.generate_code_challenge(code_verifier, code_challenge_method),

social_core/tests/test_pipeline.py

@@ -27,7 +27,7 @@ def get_social_auth(cls, provider, uid):
             cls._called_times = 0
         cls._called_times += 1
         if cls._called_times == 2:
-            user = list(User.cache.values())[0]
+            user = next(iter(User.cache.values()))
             return IntegrityErrorUserSocialAuth(user, provider, uid)
         return super().get_social_auth(provider, uid)