chore: move return statements outside try block

The try/except block should be used only for code expected to fail.

Author: nijel

pyproject.toml

@@ -151,8 +151,7 @@ ignore = [
   "PLW0603",  # TODO: Using the global statement to update `BACKENDSCACHE` is discouraged
   "TRY301",  # TODO: Abstract `raise` to an inner function
   "BLE001",  # TODO: Do not catch blind exception: `Exception`
-  "S110",  # TODO: `try`-`except`-`pass` detected, consider logging the exception
-  "TRY300"  # TODO: Consider moving this statement to an `else` block
+  "S110"  # TODO: `try`-`except`-`pass` detected, consider logging the exception
 ]
 select = ["ALL"]
 

social_core/backends/line.py

@@ -98,6 +98,7 @@ def user_data(self, access_token, *args, **kwargs):
                 self.USER_INFO_URL, headers={"Authorization": f"Bearer {access_token}"}
             )
             self.process_error(response)
-            return response
         except requests.HTTPError as err:
             self.process_error(err.response.json())
+            return None
+        return response

social_core/backends/uffd.py

@@ -40,9 +40,9 @@ def user_data(self, access_token, *args, **kwargs):
         url = self.userinfo_url() + "?" + urlencode({"access_token": access_token})
         try:
             user_data: dict[str, Any] = self.get_json(url)
-            return user_data
         except ValueError:
             return None
+        return user_data
 
     def authorization_url(self):
         return self.setting("BASE_URL") + "/oauth2/authorize"