feat: introduce AuthConnectionError for connection errors

This makes it possible to handle these specifically in the caller.

Fixes #916

Author: nijel

pyproject.toml

@@ -127,7 +127,6 @@ ignore = [
   "B018",  # TODO: Found useless expression.
   "A001",  # TODO: Variable is shadowing a Python builtin
   "A002",  # TODO: Function argument is shadowing a Python builtin
-  "A004",  # TODO: Import `ConnectionError` is shadowing a Python builtin
   "ERA001",  # TODO: Found commented-out code
   "EM101",  # TODO: Exception must not use a string literal, assign to variable first
   "EM102",  # TODO: Exception must not use an f-string literal, assign to variable first

social_core/backends/base.py

@@ -1,9 +1,9 @@
 import time
 from typing import Any
 
-from requests import ConnectionError, request
+import requests
 
-from ..exceptions import AuthFailed
+from ..exceptions import AuthConnectionError
 from ..utils import module_member, parse_qs, user_agent
 
 
@@ -236,9 +236,9 @@ def request(self, url, method="GET", *args, **kwargs):
             kwargs["headers"]["User-Agent"] = self.setting("USER_AGENT") or user_agent()
 
         try:
-            response = request(method, url, *args, **kwargs)
-        except ConnectionError as err:
-            raise AuthFailed(self, str(err))
+            response = requests.request(method, url, *args, **kwargs)
+        except requests.ConnectionError as err:
+            raise AuthConnectionError(self, str(err)) from err
         response.raise_for_status()
         return response
 

social_core/exceptions.py

@@ -126,3 +126,11 @@ def __str__(self):
 class InvalidEmail(AuthException):
     def __str__(self):
         return "Email couldn't be validated"
+
+
+class AuthConnectionError(AuthException):
+    """Connection error duing authentication."""
+
+    def __str__(self):
+        msg = super().__str__()
+        return f"Connection error: {msg}"