all tests passing 🎉

Author: jakkdl

flake8_async/visitors/visitors.py

@@ -121,10 +121,10 @@ def visit_With(self, node: ast.With | ast.AsyncWith):
             elif get_matching_call(
                 item.context_expr, "create_task_group", base="anyio"
             ):
-                nursery_type = "taskgroup"
+                nursery_type = "task group"
             # check for asyncio.TaskGroup
             elif get_matching_call(item.context_expr, "TaskGroup", base="asyncio"):
-                nursery_type = "taskgroup"
+                nursery_type = "task group"
                 start_methods = ("create_task",)
             else:
                 # incorrectly marked as not covered on py39
@@ -213,12 +213,16 @@ def is_nursery_call(node: ast.expr):
             ):
                 return False
             var = ast.unparse(node.value)
-            return ("trio" in self.library and var.endswith("nursery")) or (
-                self.variables.get(var, "")
-                in (
-                    "trio.Nursery",
-                    "anyio.TaskGroup",
-                    "asyncio.TaskGroup",
+            return (
+                ("trio" in self.library and var.endswith("nursery"))
+                or ("anyio" in self.library and var.endswith("task_group"))
+                or (
+                    self.variables.get(var, "")
+                    in (
+                        "trio.Nursery",
+                        "anyio.TaskGroup",
+                        "asyncio.TaskGroup",
+                    )
                 )
             )
 

tests/autofix_files/async100_anyio.py

@@ -1,6 +1,5 @@
 # AUTOFIX
 # BASE_LIBRARY anyio
-# NOTRIO  # trio.create_task_group doesn't exist
 # ASYNCIO_NO_ERROR
 import anyio
 

tests/autofix_files/async100_trio.py

@@ -1,6 +1,5 @@
 # AUTOFIX
 # ASYNCIO_NO_ERROR # asyncio.open_nursery doesn't exist
-# NOANYIO # anyio.open_nursery doesn't exist
 import trio
 
 

tests/eval_files/async100_anyio.py

@@ -1,6 +1,5 @@
 # AUTOFIX
 # BASE_LIBRARY anyio
-# NOTRIO  # trio.create_task_group doesn't exist
 # ASYNCIO_NO_ERROR
 import anyio
 

tests/eval_files/async100_trio.py

@@ -1,6 +1,5 @@
 # AUTOFIX
 # ASYNCIO_NO_ERROR # asyncio.open_nursery doesn't exist
-# NOANYIO # anyio.open_nursery doesn't exist
 import trio
 
 

tests/eval_files/async101.py

@@ -2,10 +2,6 @@
 # ARG --no-checkpoint-warning-decorator=no_checkpoint_warning_decorator
 # ARG --transform-async-generator-decorators=transform_async_gen_decorator
 
-# This file contains errors shared between trio and anyio, since they have some
-# overlap in naming.
-# See async101_xxx which has errors specific to trio/asyncio/anyio.
-
 
 import contextlib
 import contextlib as bla
@@ -149,3 +145,14 @@ def no_checkpoint_warning_deco_fun():
 def transfor_async_gen_deco_fun():
     with trio.CancelScope():
         yield 1  # safe
+
+
+async def foo_open_nursery():
+    async with trio.open_nursery() as _:
+        yield 1  # error: 8
+
+
+@asynccontextmanager
+async def foo_open_nursery_contextmanager():
+    async with trio.open_nursery() as _:
+        yield 1  # safe

tests/eval_files/async101_anyio.py

@@ -1,5 +1,4 @@
 # BASE_LIBRARY anyio
-# TRIO_NO_ERROR
 # ASYNCIO_NO_ERROR
 
 import anyio

tests/eval_files/async101_trio.py

@@ -1,5 +1,4 @@
 # ASYNCIO_NO_ERROR
-# ANYIO_NO_ERROR
 
 from contextlib import asynccontextmanager
 

tests/eval_files/async111.py

@@ -3,7 +3,6 @@
 # It's possible there's an equivalent asyncio construction/gotcha, but methods are differently named, so this file will not raise any errors
 # nurseries are named taskgroups in asyncio/anyio
 # ASYNCIO_NO_ERROR
-# ANYIO_NO_ERROR
 from typing import Any
 
 import trio

tests/eval_files/async111_anyio.py

@@ -2,7 +2,6 @@
 # this only tests anyio.create_task_group in particular
 # BASE_LIBRARY anyio
 # ASYNCIO_NO_ERROR
-# TRIO_NO_ERROR
 
 
 import anyio