Merge pull request #3044 from CoolCat467/enable-flake8-commas

Enable ruff's `flake8-commas` rule

Author: CoolCat467

.git-blame-ignore-revs

@@ -1,2 +1,4 @@
 # sorting all imports with isort
 933f77b96f0092e1baab4474a9208fc2e379aa32
+# enabling ruff's flake8-commas rule
+b25c02a94e2defcb0fad32976b02218be1133bdf

docs/source/conf.py

@@ -132,7 +132,8 @@ def autodoc_process_signature(
             # and insert the fully-qualified name.
             signature = signature.replace("+E", "~trio.testing._raises_group.E")
             signature = signature.replace(
-                "+MatchE", "~trio.testing._raises_group.MatchE"
+                "+MatchE",
+                "~trio.testing._raises_group.MatchE",
             )
         if "DTLS" in name:
             signature = signature.replace("SSL.Context", "OpenSSL.SSL.Context")

notes-to-self/afd-lab.py

@@ -125,7 +125,7 @@ async def afd_poll(self, sock, flags, *, exclusive=0):
                     ffi.sizeof("AFD_POLL_INFO"),
                     ffi.NULL,
                     lpOverlapped,
-                )
+                ),
             )
         except OSError as exc:
             if exc.winerror != ErrorCodes.ERROR_IO_PENDING:  # pragma: no cover

notes-to-self/blocking-read-hack.py

@@ -12,7 +12,9 @@ class BlockingReadTimeoutError(Exception):
 
 
 async def blocking_read_with_timeout(
-    fd, count, timeout  # noqa: ASYNC109  # manual timeout
+    fd,
+    count,
+    timeout,  # noqa: ASYNC109  # manual timeout
 ):
     print("reading from fd", fd)
     cancel_requested = False

notes-to-self/file-read-latency.py

@@ -23,5 +23,5 @@
         seek = (end - between) / COUNT * 1e9
         read = both - seek
         print(
-            f"{both:.2f} ns/(seek+read), {seek:.2f} ns/seek, estimate ~{read:.2f} ns/read"
+            f"{both:.2f} ns/(seek+read), {seek:.2f} ns/seek, estimate ~{read:.2f} ns/read",
         )

notes-to-self/how-does-windows-so-reuseaddr-work.py

@@ -49,7 +49,7 @@ def table_entry(mode1, bind_type1, mode2, bind_type2):
     """
                                                        second bind
                                | """
-    + " | ".join(["%-19s" % mode for mode in modes])
+    + " | ".join(["%-19s" % mode for mode in modes]),
 )
 
 print("""                              """, end="")
@@ -58,7 +58,7 @@ def table_entry(mode1, bind_type1, mode2, bind_type2):
 
 print(
     """
-first bind                     -----------------------------------------------------------------"""
+first bind                     -----------------------------------------------------------------""",
     #            default | wildcard |    INUSE |  Success |   ACCESS |  Success |    INUSE |  Success
 )
 
@@ -72,5 +72,5 @@ def table_entry(mode1, bind_type1, mode2, bind_type2):
                 # print(mode1, bind_type1, mode2, bind_type2, entry)
         print(
             f"{mode1:>19} | {bind_type1:>8} | "
-            + " | ".join(["%8s" % entry for entry in row])
+            + " | ".join(["%8s" % entry for entry in row]),
         )

notes-to-self/manual-signal-handler.py

@@ -11,11 +11,12 @@
         """
         void* WINAPI GetProcAddress(void* hModule, char* lpProcName);
         typedef void (*PyOS_sighandler_t)(int);
-    """
+    """,
     )
     kernel32 = ffi.dlopen("kernel32.dll")
     PyOS_getsig_ptr = kernel32.GetProcAddress(
-        ffi.cast("void*", sys.dllhandle), b"PyOS_getsig"
+        ffi.cast("void*", sys.dllhandle),
+        b"PyOS_getsig",
     )
     PyOS_getsig = ffi.cast("PyOS_sighandler_t (*)(int)", PyOS_getsig_ptr)
 

notes-to-self/proxy-benchmarks.py

@@ -54,7 +54,7 @@ def add_wrapper(cls, method):
         f"""
         def wrapper(self, *args, **kwargs):
             return self._wrapped.{method}(*args, **kwargs)
-    """
+    """,
     )
     ns = {}
     exec(code, ns)
@@ -113,7 +113,7 @@ def setter(self, newval):
 
         def deleter(self):
             del self._wrapped.{attr}
-    """
+    """,
     )
     ns = {}
     exec(code, ns)

notes-to-self/ssl-handshake/ssl-handshake.py

@@ -27,7 +27,9 @@ def echo_server_connection():
     client_sock, server_sock = socket.socketpair()
     with client_sock, server_sock:
         t = threading.Thread(
-            target=_ssl_echo_serve_sync, args=(server_sock,), daemon=True
+            target=_ssl_echo_serve_sync,
+            args=(server_sock,),
+            daemon=True,
         )
         t.start()
 
@@ -101,7 +103,9 @@ def wrap_socket_via_wrap_bio(ctx, sock, **kwargs):
     with echo_server_connection() as client_sock:
         client_ctx = ssl.create_default_context(cafile="trio-test-CA.pem")
         wrapped = wrap_socket(
-            client_ctx, client_sock, server_hostname="trio-test-1.example.org"
+            client_ctx,
+            client_sock,
+            server_hostname="trio-test-1.example.org",
         )
         wrapped.do_handshake()
         wrapped.sendall(b"x")
@@ -113,7 +117,9 @@ def wrap_socket_via_wrap_bio(ctx, sock, **kwargs):
     with echo_server_connection() as client_sock:
         client_ctx = ssl.create_default_context(cafile="trio-test-CA.pem")
         wrapped = wrap_socket(
-            client_ctx, client_sock, server_hostname="trio-test-2.example.org"
+            client_ctx,
+            client_sock,
+            server_hostname="trio-test-2.example.org",
         )
         try:
             wrapped.do_handshake()
@@ -126,7 +132,9 @@ def wrap_socket_via_wrap_bio(ctx, sock, **kwargs):
     with echo_server_connection() as client_sock:
         client_ctx = ssl.create_default_context(cafile="trio-test-CA.pem")
         wrapped = wrap_socket(
-            client_ctx, client_sock, server_hostname="trio-test-2.example.org"
+            client_ctx,
+            client_sock,
+            server_hostname="trio-test-2.example.org",
         )
         # We forgot to call do_handshake
         # But the hostname is wrong so something had better error out...

notes-to-self/wakeup-fd-racer.py

@@ -91,7 +91,7 @@ def main():
         if duration < 2:
             print(
                 f"Attempt {attempt}: OK, trying again "
-                f"(select_calls = {select_calls}, drained = {drained})"
+                f"(select_calls = {select_calls}, drained = {drained})",
             )
         else:
             print(f"Attempt {attempt}: FAILED, took {duration} seconds")