Skip to content

Commit 980db2b

Browse files
committed
PR feedback
1 parent ef54ef3 commit 980db2b

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

newsfragments/3403.deprecated.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
Trying to use absolute deadlines on a `trio.CancelScope` constructed
22
with a relative deadline now raises, after being deprecated since Trio
33
0.27.0.
4+
5+
To move over, replace the `trio.CancelScope` object instead of mutating
6+
it.

src/trio/_tests/test_timeouts.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,13 +243,12 @@ async def test_timeout_deadline_on_entry(mock_clock: _core.MockClock) -> None:
243243
assert rcs is cs
244244

245245

246-
async def test_invalid_access_unentered(mock_clock: _core.MockClock) -> None:
246+
async def test_invalid_access_unentered() -> None:
247247
cs = move_on_after(5)
248-
mock_clock.jump(3)
249248

250249
match_str = "^Unentered relative cancel scope does not have an absolute deadline"
251250
with pytest.raises(RuntimeError, match=match_str):
252-
print("SHOULD NOT PRINT! deadline:", cs.deadline)
251+
assert cs.deadline
253252

254253
with pytest.raises(RuntimeError, match=match_str):
255254
cs.deadline = 7

0 commit comments

Comments
 (0)