Skip to content

Commit ffa0ae9

Browse files
feat(ci): remove codecov step from tox since performed in GA (#719)
There is no need to perform the non-working `codecov` step via `tox` since we now have a Github Actions step that performs it.
1 parent 6dbf606 commit ffa0ae9

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/workflows/testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
- name: Test with tox
103103
run: tox -e ${TOX_VENV}
104104
env:
105-
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl,codecov') }}
105+
TOX_VENV: ${{ format('{0}-{1}', matrix.tox-env, 'gevent-eventlet-sasl') }}
106106
ZOOKEEPER_VERSION: ${{ matrix.zk-version }}
107107
# TODO: can be removed once tests for ZK 3.4 are removed
108108
ZOOKEEPER_PREFIX: "${{ !contains(matrix.zk-version, '3.4') && 'apache-' || '' }}"

tox.ini

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ extras =
2929
sasl: sasl
3030
deps =
3131
sasl: kerberos
32-
codecov: codecov
3332
allowlist_externals =
3433
{toxinidir}/ensure-zookeeper-env.sh
3534
{toxinidir}/init_krb5.sh
@@ -40,9 +39,6 @@ commands =
4039

4140
[testenv:build]
4241

43-
[testenv:codecov]
44-
commands = - codecov -e TOX_VENV,ZOOKEEPER_VERSION
45-
4642
[testenv:pep8]
4743
basepython = python3
4844
extras = alldeps

0 commit comments

Comments
 (0)