Skip to content

Commit 4a23787

Browse files
committed
Skip having a PR builder for nondebug WASI
A confluence of file locations moving between versions and `wasi.py` only being available starting in Python 3.13 is causing this. It's just easier to rely on the debug PR builder.
1 parent f7085ef commit 4a23787

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

master/master.cfg

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
325325
# 10pm UTC and 2am UTC, it will be delayed to 2am UTC.
326326
if worker_name == "diegorusso-aarch64-bigmem":
327327
builder.canStartBuild = no_builds_between("22:00", "2:00")
328-
328+
329329
# This worker restarts every day at 9am UTC to work around issues stemming from
330330
# failing bigmem tests trashing disk space and fragmenting RAM. Builds scheduled
331331
# between 07:20am - 9:20am UTC will be delayed to 9:20am UTC.
@@ -366,10 +366,6 @@ all_pull_request_builders = []
366366

367367
for name, worker_name, buildfactory, stability, tier in BUILDERS:
368368
buildername = f"{name} PR"
369-
all_pull_request_builders.append(buildername)
370-
if stability == STABLE:
371-
stable_pull_request_builders.append(buildername)
372-
373369
source = GitHub(repourl=git_url, **GIT_KWDS)
374370

375371
f = buildfactory(
@@ -386,6 +382,14 @@ for name, worker_name, buildfactory, stability, tier in BUILDERS:
386382
if tier:
387383
tags.append(tier)
388384

385+
# The nondebug WASI builder does not work across all Python versions
386+
# due to some file locations being different and `wasi.py` not being
387+
# available.
388+
# As such, it's just easier to skip the builder entirely for PRs.
389+
# This can be removed once we are only supporting >= 3.13.
390+
if "wasm" in tags and "nondebug" in tags:
391+
continue
392+
389393
builder = util.BuilderConfig(
390394
name=buildername,
391395
workernames=[worker_name],
@@ -402,6 +406,9 @@ for name, worker_name, buildfactory, stability, tier in BUILDERS:
402406
builder.canStartBuild = no_builds_between("22:00", "2:00")
403407

404408
c["builders"].append(builder)
409+
all_pull_request_builders.append(buildername)
410+
if stability == STABLE:
411+
stable_pull_request_builders.append(buildername)
405412

406413
c["schedulers"].append(
407414
GitHubPrScheduler(

0 commit comments

Comments
 (0)